[FIX] snippet editor for complex options (website_animate) #31440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qsm-odoo
force-pushed
the
11.0-website-animate-fix-qsm
branch
from
ea002a0
to
d3d74da
Compare
qsm-odoo
force-pushed
the
11.0-website-animate-fix-qsm
branch
from
d3d74da
to
d76ebe8
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
Staging failed: ci/runbot on f6bbf03266d94b047ce6bd629f8df54b2cc5b36b (view more at http://runbot.odoo.com/runbot/build/471324) |
Commit odoo@c2b8d2a made the mistake of considering each dropdown-menu individually while all are considered to be the same when enabling a class. From saas-11.x, commit odoo@8ca9233 will group by dropdown menu but that will be another fix to make. Part of odoo#31440 opw-1929133
Part of odoo#31440 opw-1929133
qsm-odoo
force-pushed
the
11.0-website-animate-fix-qsm
branch
from
d76ebe8
to
2baf110
Compare
|
@robodoo retry |
|
Merged, thanks! |
qsm-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 15, 2019
Commit odoo@8ca9233 did not think about submenus inside submenus, which is the case in the website animate option. This made snippets potentially have multiple animations on them, with undesired behaviors. This commit also accordingly reviews the _setActive method for the select-class option and also adapts following the recent forward-port of odoo#31440 Related to task-1929133
robodoo
pushed a commit
that referenced
this pull request
Mar 15, 2019
Commit 8ca9233 did not think about submenus inside submenus, which is the case in the website animate option. This made snippets potentially have multiple animations on them, with undesired behaviors. This commit also accordingly reviews the _setActive method for the select-class option and also adapts following the recent forward-port of #31440 Related to task-1929133 closes #31477 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Zynton
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Aug 7, 2019
Part of odoo#31440 opw-1929133 closes odoo#31440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opw-1929133