Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE] website_blog, *: review blog layouts #31749

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@kea14
Copy link
Contributor

commented Mar 11, 2019

  • website

Review the blog layouts to

  • Use cards where necessary to match the forum / event redesign
  • Use correct bootstrap / HTML
  • Some minor improvements

task-1948882

@robodoo robodoo added the seen 🙂 label Mar 11, 2019

@kea14 kea14 requested a review from qsm-odoo Mar 11, 2019

@kea14 kea14 changed the title Review blog layouts [website_blog] review blog layouts Mar 11, 2019

@C3POdoo C3POdoo added the RD label Mar 11, 2019

@robodoo robodoo added the CI 🤖 label Mar 11, 2019

@kea14 kea14 force-pushed the odoo-dev:master-review-blog-layouts-aul branch Mar 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 12, 2019

@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@qsm-odoo Before you take a look at the code, here is one question concerning the grid view (which works now but maybe not as expected). As I am now using bootstrap grid system and elements sometimes do not have the same height, this occurs : https://ibb.co/Xz7sKrW. Am I supposed to handle this with bootstrap (clearfix,... ?) or maybe with masonry or ... ? Thanks 😄

@kea14 kea14 force-pushed the odoo-dev:master-review-blog-layouts-aul branch Mar 13, 2019

@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@qsm-odoo I finally used Cards-columns directly from Bootstrap. You can check the code, everything seems good physically 😄

@robodoo robodoo removed the CI 🤖 label Mar 13, 2019

@kea14 kea14 force-pushed the odoo-dev:master-review-blog-layouts-aul branch 2 times, most recently Mar 13, 2019

@robodoo robodoo added the CI 🤖 label Mar 13, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

@kea14 Is the order preserved with card-columns ?

@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@qsm-odoo Indeed... Order seems to be left to right : https://ibb.co/QMhvMy9 😞

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

As written in the doc ;) So it is not a viable solution. So I suppose there is only one solution: force the column to all have the same height (which should be the default when using the bootstrap grid system anyway). But I don't know, I have not investigated, do your best so that it looks good and the order is preserved :)

@kea14 kea14 force-pushed the odoo-dev:master-review-blog-layouts-aul branch to 9fe0db1 Mar 13, 2019

@robodoo robodoo removed the CI 🤖 label Mar 13, 2019

@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@qsm-odoo Final result for a blog post https://ibb.co/HqLnCzt Seems ok for you ? :)

@robodoo robodoo added the CI 🤖 label Mar 13, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Screenshot seems good 😉 Are you finished with the task or have you still something to improve ?

@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@qsm-odoo No, the task is done :)

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-review-blog-layouts-aul branch from 9fe0db1 to debcc61 Mar 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 19, 2019

</xpath>
<xpath expr="//div[@id='blog_right_column']" position="inside">
<section class="mt32 mb32" groups="website.group_website_designer">

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Mar 19, 2019

Contributor

@kea14 I am working on this task. Comment about this (do not fix as I take care of this branch now): be careful, you removed a groups here, which means that all visitors would have had access to this panel :|

@robodoo robodoo removed the CI 🤖 label Mar 19, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-review-blog-layouts-aul branch from 9c9874f to 12955c4 Mar 28, 2019

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 28, 2019

[IMP] website_blog: review blog layouts
Review our blog layouts to follow the design we added for forum and
event (usings cards for records but not for menu + colored cards for
the right column). Also fixes some DOM/Bootstrap structures.

Part of odoo#31749
task-1948882

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 28, 2019

[IMP] website_blog, *: improve social links visual
* website

Use real social colors which makes the blogs look more modern.
Introduce the colors for github, instagram and youtube.

Part of odoo#31749
task-1948882

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 28, 2019

[REF] website_blog: review blog redesign
- No cards for menus
- Use the grid system for better blog post card footers
- Correct grid system for blog list grid view
- Remove some useless custom css
- Restore 'groups' in xml data
- ...

Part of odoo#31749
task-1948882

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 28, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-review-blog-layouts-aul branch from 12955c4 to 53f8062 Mar 29, 2019

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 29, 2019

[REF] website_blog: review blog redesign
- No cards for menus
- Use the grid system for better blog post card footers
- Correct grid system for blog list grid view
- Remove some useless custom css
- Restore 'groups' in xml data
- ...

Part of odoo#31749
task-1948882

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 29, 2019

kea14 and others added some commits Mar 13, 2019

[IMP] website_blog: review blog layouts
Review our blog layouts to follow the design we added for forum and
event (usings cards for records but not for menu + colored cards for
the right column). Also fixes some DOM/Bootstrap structures.

Part of #31749
task-1948882
[IMP] website_blog, *: improve social links visual
* website

Use real social colors which makes the blogs look more modern.
Introduce the colors for github, instagram and youtube.

Part of #31749
task-1948882
[REF] website_blog: review blog redesign
- No cards for menus
- Use the grid system for better blog post card footers
- Correct grid system for blog list grid view
- Remove some useless custom css
- Restore 'groups' in xml data
- ...

Part of #31749
task-1948882

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-review-blog-layouts-aul branch from 53f8062 to 2d5e177 Mar 29, 2019

@robodoo robodoo removed the CI 🤖 label Mar 29, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@robodoo rebase-merge

@robodoo robodoo added the r+ 👌 label Mar 29, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo robodoo added the CI 🤖 label Mar 29, 2019

robodoo pushed a commit that referenced this pull request Mar 29, 2019

[IMP] website_blog: review blog layouts
Review our blog layouts to follow the design we added for forum and
event (usings cards for records but not for menu + colored cards for
the right column). Also fixes some DOM/Bootstrap structures.

Part of #31749
task-1948882

robodoo pushed a commit that referenced this pull request Mar 29, 2019

[IMP] website_blog, *: improve social links visual
* website

Use real social colors which makes the blogs look more modern.
Introduce the colors for github, instagram and youtube.

Part of #31749
task-1948882

robodoo pushed a commit that referenced this pull request Mar 29, 2019

[REF] website_blog: review blog redesign
- No cards for menus
- Use the grid system for better blog post card footers
- Correct grid system for blog list grid view
- Remove some useless custom css
- Restore 'groups' in xml data
- ...

Part of #31749
task-1948882

robodoo added a commit that referenced this pull request Mar 29, 2019

[MERGE] website_blog, *: review blog layouts
* website

Review the blog layouts to
- Use cards where necessary to match the forum / event redesign
- Use correct bootstrap / HTML

+ Some minor improvements

task-1948882

closes #31749

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 29, 2019

@qsm-odoo qsm-odoo deleted the odoo-dev:master-review-blog-layouts-aul branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.