Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MERGE] website_blog, *: review blog layouts #31749

Closed
wants to merge 3 commits into from
Closed

[MERGE] website_blog, *: review blog layouts #31749

wants to merge 3 commits into from

Conversation

kea14
Copy link
Contributor

@kea14 kea14 commented Mar 11, 2019 •
edited by qsm-odoo
Loading

  • website

Review the blog layouts to

  • Use cards where necessary to match the forum / event redesign
  • Use correct bootstrap / HTML
  • Some minor improvements

task-1948882

@kea14 kea14 requested a review from qsm-odoo March 11, 2019 14:49
@kea14 kea14 changed the title Review blog layouts [website_blog] review blog layouts Mar 11, 2019
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 11, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 11, 2019
@kea14 kea14 force-pushed the master-review-blog-layouts-aul branch from 17d502d to 063f08b Compare March 12, 2019 07:32
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 12, 2019
@kea14
Copy link
Contributor Author

kea14 commented Mar 12, 2019

@qsm-odoo Before you take a look at the code, here is one question concerning the grid view (which works now but maybe not as expected). As I am now using bootstrap grid system and elements sometimes do not have the same height, this occurs : https://ibb.co/Xz7sKrW. Am I supposed to handle this with bootstrap (clearfix,... ?) or maybe with masonry or ... ? Thanks 😄

@kea14 kea14 force-pushed the master-review-blog-layouts-aul branch from 063f08b to 867cd86 Compare March 13, 2019 08:24
@kea14
Copy link
Contributor Author

kea14 commented Mar 13, 2019

@qsm-odoo I finally used Cards-columns directly from Bootstrap. You can check the code, everything seems good physically 😄

@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Mar 13, 2019
@kea14 kea14 force-pushed the master-review-blog-layouts-aul branch 2 times, most recently from 64b8d42 to 08cec7b Compare March 13, 2019 08:31
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 13, 2019
@qsm-odoo
Copy link
Contributor

@kea14 Is the order preserved with card-columns ?

@kea14
Copy link
Contributor Author

kea14 commented Mar 13, 2019

@qsm-odoo Indeed... Order seems to be left to right : https://ibb.co/QMhvMy9 😞

@qsm-odoo
Copy link
Contributor

As written in the doc ;) So it is not a viable solution. So I suppose there is only one solution: force the column to all have the same height (which should be the default when using the bootstrap grid system anyway). But I don't know, I have not investigated, do your best so that it looks good and the order is preserved :)

@kea14 kea14 force-pushed the master-review-blog-layouts-aul branch from 08cec7b to 9fe0db1 Compare March 13, 2019 11:12
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Mar 13, 2019
@kea14
Copy link
Contributor Author

kea14 commented Mar 13, 2019

@qsm-odoo Final result for a blog post https://ibb.co/HqLnCzt Seems ok for you ? :)

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 13, 2019
@qsm-odoo
Copy link
Contributor

Screenshot seems good 😉 Are you finished with the task or have you still something to improve ?

@kea14
Copy link
Contributor Author

kea14 commented Mar 13, 2019

@qsm-odoo No, the task is done :)

@qsm-odoo qsm-odoo force-pushed the master-review-blog-layouts-aul branch from 9fe0db1 to debcc61 Compare March 19, 2019 13:06
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 19, 2019
qsm-odoo
qsm-odoo reviewed Mar 19, 2019
View reviewed changes
addons/website_blog/views/website_blog_templates.xml
</xpath>
<xpath expr="//div[@id='blog_right_column']" position="inside">
<section class="mt32 mb32" groups="website.group_website_designer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kea14 I am working on this task. Comment about this (do not fix as I take care of this branch now): be careful, you removed a groups here, which means that all visitors would have had access to this panel :|

@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Mar 19, 2019
@qsm-odoo qsm-odoo force-pushed the master-review-blog-layouts-aul branch from 9c9874f to 12955c4 Compare March 28, 2019 17:30
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 28, 2019
@qsm-odoo qsm-odoo force-pushed the master-review-blog-layouts-aul branch from 12955c4 to 53f8062 Compare March 29, 2019 15:05
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 29, 2019
kea14 and others added 3 commits March 29, 2019 17:37
@kea14 @qsm-odoo
[IMP] website_blog: review blog layouts
c852df6 
Review our blog layouts to follow the design we added for forum and
event (usings cards for records but not for menu + colored cards for
the right column). Also fixes some DOM/Bootstrap structures.

Part of odoo#31749
task-1948882
@qsm-odoo
[IMP] website_blog, *: improve social links visual
bfd9a29 
* website

Use real social colors which makes the blogs look more modern.
Introduce the colors for github, instagram and youtube.

Part of odoo#31749
task-1948882
@qsm-odoo
[REF] website_blog: review blog redesign
2d5e177 
- No cards for menus
- Use the grid system for better blog post card footers
- Correct grid system for blog list grid view
- Remove some useless custom css
- Restore 'groups' in xml data
- ...

Part of odoo#31749
task-1948882
@qsm-odoo qsm-odoo force-pushed the master-review-blog-layouts-aul branch from 53f8062 to 2d5e177 Compare March 29, 2019 16:40
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Mar 29, 2019
@qsm-odoo
Copy link
Contributor

@robodoo r+

@qsm-odoo
Copy link
Contributor

@robodoo rebase-merge

@robodoo
Copy link
Contributor

robodoo commented Mar 29, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 29, 2019
robodoo pushed a commit that referenced this pull request Mar 29, 2019
@kea14 @qsm-odoo
[IMP] website_blog: review blog layouts
1967ea8 
Review our blog layouts to follow the design we added for forum and
event (usings cards for records but not for menu + colored cards for
the right column). Also fixes some DOM/Bootstrap structures.

Part of #31749
task-1948882
robodoo pushed a commit that referenced this pull request Mar 29, 2019
@qsm-odoo
[IMP] website_blog, *: improve social links visual
217ba16 
* website

Use real social colors which makes the blogs look more modern.
Introduce the colors for github, instagram and youtube.

Part of #31749
task-1948882
robodoo pushed a commit that referenced this pull request Mar 29, 2019
@qsm-odoo
[REF] website_blog: review blog redesign
24aec08 
- No cards for menus
- Use the grid system for better blog post card footers
- Correct grid system for blog list grid view
- Remove some useless custom css
- Restore 'groups' in xml data
- ...

Part of #31749
task-1948882
robodoo added a commit that referenced this pull request Mar 29, 2019
@robodoo
[MERGE] website_blog, *: review blog layouts
3ccccd1 
* website

Review the blog layouts to
- Use cards where necessary to match the forum / event redesign
- Use correct bootstrap / HTML

+ Some minor improvements

task-1948882

closes #31749

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Mar 29, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 29, 2019
@qsm-odoo qsm-odoo deleted the master-review-blog-layouts-aul branch April 1, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qsm-odoo qsm-odoo qsm-odoo left review comments

Assignees

@kea14 kea14

Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kea14 @qsm-odoo @robodoo @C3POdoo