Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] mail: adding database name in the url of company logo #31772

Closed
wants to merge 1 commit into from
Closed

[IMP] mail: adding database name in the url of company logo #31772

wants to merge 1 commit into from

Conversation

kma-odoo
Copy link
Contributor

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 12, 2019
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 12, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from a9ef333 to 3e0a322 Compare March 12, 2019 12:03
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 12, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 3e0a322 to 43ea593 Compare March 12, 2019 13:34
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 12, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 43ea593 to 2266c74 Compare March 13, 2019 12:50
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 13, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 2266c74 to e5bb717 Compare March 14, 2019 06:55
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 14, 2019
@mba-odoo mba-odoo force-pushed the master-mail-company-logo-kma branch from e5bb717 to 6c6c1f3 Compare April 1, 2019 10:23
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 1, 2019
@mba-odoo mba-odoo force-pushed the master-mail-company-logo-kma branch from 6c6c1f3 to 8990642 Compare April 1, 2019 11:48
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 1, 2019
@mba-odoo mba-odoo force-pushed the master-mail-company-logo-kma branch from 8990642 to 2385460 Compare April 1, 2019 11:50
mba-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Apr 1, 2019
@kma-odoo @mba-odoo
[IMP] mail: adding database name in the url of company logo
2385460 
In the mail templates, when the logo of the company is needed, by default,
we use the route <domain_name>/logo.

In some cases the system does not manage to "guess" which DB or company to use
and this gives the default Odoo logo which can be problematic.

In this commit, we're adding database name as a parameter in logo url to overcome this issue.

Task-ID: 1889370
Closes : odoo#31772
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 1, 2019
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 15, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch 2 times, most recently from 9329ec6 to 0aff561 Compare May 16, 2019 11:05
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 0aff561 to 72734e7 Compare May 20, 2019 06:41
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 72734e7 to b48bf28 Compare May 20, 2019 10:31
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 23, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 4c01926 to 92c25a2 Compare May 30, 2019 08:42
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 30, 2019
hmo-odoo
hmo-odoo reviewed Jun 4, 2019
View reviewed changes
addons/auth_signup/data/auth_signup_data.xml
@@ -26,7 +26,7 @@
${object.name}
</span>
</td><td valign="middle" align="right">
<img src="/logo.png?company=${object.company_id.id}" style="padding: 0px; margin: 0px; height: auto; width: 80px;" alt="${object.company_id.name}"/>
<img src="/logo.png?company=${object.company_id.id}&amp;dbname=${object.env.cr.dbname}" style="padding: 0px; margin: 0px; height: auto; width: 80px;" alt="${object.company_id.name}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tivisse

we use "company" parameter in company_logo controller. https://github.com/odoo/odoo/blob/master/addons/web/controllers/main.py#L1185

I think we have to use "cids" parameter for a company in every url.

can we rename "company" with "cids" in company_logo controller?

cc @tde-banana-odoo

@mba-odoo mba-odoo force-pushed the master-mail-company-logo-kma branch from 92c25a2 to 8729318 Compare June 6, 2019 09:51
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 6, 2019
@mba-odoo mba-odoo force-pushed the master-mail-company-logo-kma branch from 8729318 to 784733d Compare June 10, 2019 04:57
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 10, 2019
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 784733d to 702af99 Compare June 21, 2019 06:48
kma-odoo added a commit to odoo-dev/odoo that referenced this pull request Jun 21, 2019
@kma-odoo
[IMP] mail, *: adding database name in the url of company logo
702af99 
* = auth_signup, digest, event, gamification, lunch, mass_mailing_crm,
mass_mailing_sale, portal, survey, website_crm_partner_assign,
website_mail_channel, website_profile, website_sale

In the mail templates, when the logo of the company is needed, by default,
we use the route <domain_name>/logo.

In some cases the system does not manage to "guess" which DB or company to use
and this gives the default Odoo logo which can be problematic.

In this commit, we're adding database name as a parameter in logo url to
overcome this issue.

task-1889370
closes odoo#31772
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 21, 2019
@kma-odoo
[IMP] mail, *: adding database name in the url of company logo
fcf2ad6 
* = auth_signup, digest, event, gamification, lunch, mass_mailing_crm,
mass_mailing_sale, portal, survey, website_crm_partner_assign,
website_mail_channel, website_profile, website_sale

In the mail templates, when the logo of the company is needed, by default,
we use the route <domain_name>/logo.

In some cases the system does not manage to "guess" which DB or company to use
and this gives the default Odoo logo which can be problematic.

In this commit, we're adding database name as a parameter in logo url to
overcome this issue.

task-1889370
closes odoo#31772
@kma-odoo kma-odoo force-pushed the master-mail-company-logo-kma branch from 702af99 to fcf2ad6 Compare July 16, 2019 05:39
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jul 16, 2019
@kma-odoo
Copy link
Contributor Author

Task cancelled.

@kma-odoo kma-odoo closed this Jul 20, 2020
@robodoo robodoo added closed 💔 and removed CI 🤖 Robodoo has seen passing statuses labels Jul 20, 2020
@kma-odoo kma-odoo deleted the master-mail-company-logo-kma branch July 20, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmo-odoo hmo-odoo hmo-odoo left review comments

Assignees
No one assigned
Labels
RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kma-odoo @hmo-odoo @C3POdoo @robodoo