Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale: fix authorized message #31903

Closed
wants to merge 1 commit into from

Conversation

johandem
Copy link
Contributor

Description of the issue/feature this PR addresses:

Remove usage of non-existing field auth_msg. This seems to be an uncaught mistake since the field never existed.

Current behavior before PR:

Field auth_msg is used but does not exist, potentially triggering runtime errors.

Desired behavior after PR is merged:

Usage of auth_msg is removed and the fallback message is displayed.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Field `auth_msg` never existed, this is an uncaught mistake. This commit
removes its usage and displays the fallback message to avoid runtime
error.

Closes odoo#31903

Co-authored-by: Marius Stedjan <marius@stedjan.com>
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 18, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 18, 2019
@johandem johandem requested a review from tbe-odoo March 19, 2019 08:18
@johandem johandem force-pushed the 12.0-fix-authorized-msg-jde branch from 9f6053f to f592ecb Compare March 19, 2019 08:34
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Mar 19, 2019
Copy link
Contributor

@tbe-odoo tbe-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Mar 19, 2019
@robodoo robodoo added merging 👷 and removed r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Mar 19, 2019
@robodoo
Copy link
Contributor

robodoo commented Mar 19, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/481946)

@KangOl
Copy link
Contributor

KangOl commented Mar 19, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Mar 19, 2019
@robodoo robodoo closed this in 36435b4 Mar 19, 2019
@robodoo
Copy link
Contributor

robodoo commented Mar 19, 2019

Merged, thanks!

@KangOl KangOl deleted the 12.0-fix-authorized-msg-jde branch March 19, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants