Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock: late pickings #31994

Closed

Conversation

Projects
None yet
3 participants
@nim-odoo
Copy link
Contributor

commented Mar 20, 2019

With the demo data:

  • Go to Inventory
  • On the 'Delivery Order' Kanban card of YourCompany, click on 'Late'

More pickings are displayed than the expected count.

This is because the domain of the filter is not in line with the domain
of _compute_picking_count.

opw-1951090

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@nim-odoo nim-odoo self-assigned this Mar 20, 2019

@robodoo robodoo added the seen 🙂 label Mar 20, 2019

@nim-odoo nim-odoo added OE and removed seen 🙂 labels Mar 20, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 20, 2019

[FIX] stock: late pickings
With the demo data:
- Go to Inventory
- On the 'Delivery Order' Kanban card of YourCompany, click on 'Late'

More pickings are displayed than the expected count.

This is because the domain of the filter is not in line with the domain
of `_compute_picking_count`.

opw-1951090

closes #31994

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@sswapnesh

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Hello @nim-odoo
Just for reference, I have reported similar Issue at #29777 for 12.0
(Maybe you can add that on commit so It will close Issue as well once it is forward-ported to 12.0)

[FIX] stock: late pickings
With the demo data:
- Go to Inventory
- On the 'Delivery Order' Kanban card of YourCompany, click on 'Late'

More pickings are displayed than the expected count.

This is because the domain of the filter is not in line with the domain
of `_compute_picking_count`.

Closes #29777
opw-1951090

@nim-odoo nim-odoo force-pushed the odoo-dev:11.0-opw-1951090-picking_late-nim branch from 13f4896 to c538851 Mar 20, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 r+ 👌 labels Mar 20, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 21, 2019

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] stock: late pickings
With the demo data:
- Go to Inventory
- On the 'Delivery Order' Kanban card of YourCompany, click on 'Late'

More pickings are displayed than the expected count.

This is because the domain of the filter is not in line with the domain
of `_compute_picking_count`.

Closes #29777
opw-1951090

closes #31994

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 21, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 21, 2019

@nim-odoo nim-odoo deleted the odoo-dev:11.0-opw-1951090-picking_late-nim branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.