[MERGE] forward port branch saas-12.2 up to 230ad8c381e #32088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewording of "action" naming section. Task-1817988
* rewording of XML naming section * remove the convention of suffixing inherited XML ids with `_inherit_my_module, as the information is in the complete XML id name (prefixed by module name). This will avoid too long XML ids. * extend convention for the name of groups, views, ... Task-1817988
Task-1817988 closes odoo#28714 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
In 11.0 f8b38f6 improved the column group by managment when reloading several times by having the same "groupbys" dictionaries between the pivot model instance and the header menu. This has been reverted in 12.0 (with c6e7adf) because the following pivot tests failed with the change: - 'rendering of pivot view with comparison' - 'export data in excel with comparison' The failure is because now that the "groupbys" dictionaries are the same object, the truncated dictionary of a header truncate the one of the model instance. So if we search something that has no results, then something with results, the groupbys could be lost. This behavior has no reason to be and is changed in 11.0 with odoo#31644, this commit is the forward-port of f8b38f6 and odoo#31644. closes odoo#31627 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Since f8b38f6 dictionaries "groupbys" are the same object between the pivot model instance and the headers menu. But this causes an issue in 12.0 since when there is no results, the headers menu groupbys is truncated and now being the same object, the pivot model instance is also truncated. So succedding search that find results would possibly have lost the groupbys which is unexpected and breaks some 12.0 tests not expecting it. With this changeset, the groupbys are not truncated anymore. Without the change, the added test fails with: Column groupby not lost after reload after empty results expected: { "pivot_column_groupby": [ "customer" ], "pivot_measures": [ "__count" ], "pivot_row_groupby": [] } result: { "pivot_column_groupby": [], "pivot_measures": [ "__count" ], "pivot_row_groupby": [] } closes odoo#31644 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Install Invoicing (account) and uninstall it. It results to a an error because some views required by `payment.acquirer` are deleted before the acquirers. The problem is due to the way copied views are deleted, since 1388b7f they are removed before the module uninstallation. The related commit faced a similar problem where copied views were deleted too late during a module uninstallation. The two problems are revealing that the copied views have to be removed as part of the module uninstallation, more precisely after all records refering to them has been deleted but before the schemas has been cleaned. opw-1943286 closes odoo#31443 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Commit 6af6da5 introduced a duplicated term to the file .pot, which causes the following error when trying to re-load translations: ``` ON CONFLICT DO UPDATE command cannot affect row a second time HINT: Ensure that no rows proposed for insertion within the same command have duplicate constrained values. ``` This commit removes on eof the duplicates, leaving only the valid one. ``` ``` closes odoo#31683 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
closes odoo#31694 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The filter parent_res_name was already in the original search view so the duplicated one was not needed and caused to have two times the filter in the search view with possible different behavior. opw-1949559 closes odoo#31707 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
The button was referencing an image that no longer exists since 2015 closes odoo#29813 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
In saas-11.3 "Is a Landed Cost" (landed_cost_ok) was moved from the product accounting tab, to the inventory tab. The inventory tab is only shown for product not of type service, but the field should be shown when product is of type service, consu or product. With this changeset, "Is a Landed Cost" is displayed in the top and "Split Method" is hidden: to specify the split method, this needs to be done from products in Inventory > Configuration > Landed Cost Types, or by the list view of cost lines when creating a landed cost. opw-1949329 closes odoo#31714 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Since 8da3750, logger does not need to be muted anymore. This reverts commit f588930. closes odoo#31720 Signed-off-by: Christophe Simonis <chs@odoo.com>
Before this commit:
The `if` condition doing a `View._views_get` was supposed to be a sort of
'hack' for when the error occured in a child view (as the template raised would
be the parent, not the broken child).
But since we refactored that part to use etree, it was actually going into that
condition for every error even if the error was in the called template.
Proof is, we only set `editable` in that if condition, meaning going in the
else would actually prevent to show reset template.
Indeed the following code would always be true:
et = etree.fromstring(view.with_context(inherit_branding=False).read_combined(['arch'])['arch'])
node = et.find(exception.path.replace('/templates/t/', './'))
as read_combined returns all the view hierarchy DOM
Note: We could not fix this by checking exception.path against `arch` as we
could have false positive (eg the child view replace the <p> element by another
<p> element which is broken, then the path would be found in the parent view
even if the error was in the child view).
closes odoo#31515
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
- Fixes incorrect user type assignments on some accounts - Fixes incorrect account assignments on taxes - Adds a few accounts that Japanese companies would typically need - Changes some account codes to make the structure more consistent - Updates descriptions of some taxes to make them appear more natural on PDF reports closes odoo#30780 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Before this commit, users wasn't able to input values in some input elements like password, email and phone in mobile. Steps to reproduce: - Go to user - Select Preferences - Select Change password - Try to input something => The focus was lost and the keyboard disappeared In fact, a hidden input always have the focus when no other fields need it. This input is used to intercept a value from a barcode scanner. So now, we added some input types to avoid to set the focus on the barcode input. It's quite difficult to test this feature because we aren't allow to simultate a keyboard to write in a input field. See https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent Plus, we don't have the focus in mobile except if we have the cursor inside the window. So, we can't test focused elements or input values. opw-1936712 opw-1948266 closes odoo#31566 Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
Search for orders that are not abandoned Before this commit, the same results for abandoned and not abandoned were returned This was because the not abandoned domain was not negated with the '!' operator that expression.distribute_not() relies on After this commit, the abandoned domain is negated OPW 1942311 closes odoo#31739 Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
vals may be an empty dict This may happen a write is done on a computed field, the call to _write will be empty (still needed to update write_uid/date). Before this commit, all fields were read in the read call. This was unecessary and may produce acess-rights errors or other side effect (e.g. in odoo/enterprise#3778 the technical field ticket_count was read, even if not present in the view or the write call) Only compute old_values on the fields that are modified Fixes odoo/enterprise#3778 opw-1949911 closes odoo#31737 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
When register a payment, and choosing a payment acquired. Before this commit, the payment post process had to wait until a cron run (every 10 minutes). Now, The post process is executed instantly after the payment, if the payment is not yet done, the post process will be executed in the next cron run. Co-authored-by: Toufik Benjaa <tbe@odoo.com> opw-1928834 closes odoo#31732 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
When journals of type bank are created, default accounts are also created, and an account code is automatically generated. However, the number of possible automatic account codes is very limited, because only 100 different codes may be generated, and the error message "Cannot generate an unused account code" is shown. To solve the above, the number of possible account codes is raised up to 10,000 different possibilities. closes odoo#31681 Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
In case company is not set on the model related to the template, we should not try to retrieve it when creating the associated partner. Fine-tuning of a46138c opw-1947334 closes odoo#31607 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
closes odoo#31725 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
closes odoo#31728 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
closes odoo#31611 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
If the content is too long, it overflows badly. Since the height is fixed, the flex doesn't work well. opw 1924145 closes odoo#31717 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
Commit 6d67ce5 refactored the JS from multiple website modules including `website_links`. A few error needed to be fixed: - recent links would not appear anymore - graphs would not be displayed anymore - graph resize on tab change would not be fired This commit fixes it and also add some tests to be sure this module is now strongly tested. Note: tests are skipped for now as there is a race condition happening only with docker and this fix is getting urgent for Odoo.com closes odoo#31507 Signed-off-by: Romain Derie (rde) <rde@odoo.com>
ince 8da3750, logger does not need to be muted anymore. This reverts commit f588930. closes odoo#31748 Signed-off-by: Christophe Simonis <chs@odoo.com>
When search on partner_id return thousands of records, thousands of _name_get are performed, and there's a great chance to not use them at all. Using the lazy_name_get seems more efficient in terms of memory and cpu. closes odoo#31075 Signed-off-by: Christophe Simonis <chs@odoo.com>
|
Staging failed: ci/runbot on c90c478ae815602ec066a4d339382ac8fa38dc26 (view more at http://runbot.odoo.com/runbot/build/485274) |
|
@robodoo retry |
|
@robodoo p=0 |
KangOl
force-pushed
the
fp-master-1903251105
branch
from
64c3b89
to
3a7c8e1
Compare
|
@robodoo r+ p=0 |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2019
closes #32088 Signed-off-by: Christophe Simonis <chs@odoo.com>
|
'ci/runbot' failed on this reviewed PR. |
|
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/485329) |
KangOl
force-pushed
the
fp-master-1903251105
branch
from
3a7c8e1
to
9bab32f
Compare
|
@robodoo r+ p=0 |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2019
closes #32088 Signed-off-by: Christophe Simonis <chs@odoo.com>
robodoo
added
CI 🤖
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.