Master account tax type in fiscal position smo #32241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mba-odoo
force-pushed
the
master-account-tax-type-in-fiscal-position-smo
branch
from
36c940a
to
5fb3c85
Compare
robodoo
added
CI 🤖
mba-odoo
force-pushed
the
master-account-tax-type-in-fiscal-position-smo
branch
from
01946e8
to
e60c544
Compare
mba-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 12, 2019
On fiscal position, there is a mix of sales & purchases invoice which makes it difficult to understand. So display the type of tax on fiscal position and improve the name_get so type must be translated. also improve the default tree view of tax so it will display the same on 'search more' of many2one. Task-ID: 1943502 Closes: odoo#32241
oco-odoo
reviewed
May 10, 2019
| @@ -1077,7 +1077,7 @@ | |||
| <field name="model">account.tax</field> | |||
| <field name="arch" type="xml"> | |||
| <tree string="Account Tax"> | |||
| <field name="name"/> | |||
| <field name="display_name" string="name"/> | |||
There was a problem hiding this comment.
Why only in this tree view, and not the other one?
There was a problem hiding this comment.
@oco-odoo ,
when we use the search more option of many2one field dropdown at that time it will open this tree view and on that tree view we want to display the type of tax(i.e: 5% Tax(sales))
so to display type of tax based on context append_type_to_tax_name we use the display_name instead of name. while on other views we do not want to display it so keep that as it is. Thanks
|
@smo-odoo Can you rebase ? :) |
On fiscal position, there is a mix of sales & purchases invoice which makes it difficult to understand. So display the type of tax on fiscal position and improve the name_get so type must be translated. also improve the default tree view of tax so it will display the same on 'search more' of many2one. Task-ID: 1943502 Closes: odoo#32241
mba-odoo
force-pushed
the
master-account-tax-type-in-fiscal-position-smo
branch
from
e60c544
to
630b8e3
Compare
|
@oco-odoo , Done. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 10, 2019
On fiscal position, there is a mix of sales & purchases invoice which makes it difficult to understand. So display the type of tax on fiscal position and improve the name_get so type must be translated. also improve the default tree view of tax so it will display the same on 'search more' of many2one. Task-ID: 1943502 Closes: #32241 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task : https://www.odoo.com/web?debug=true#id=1943502&action=327&model=project.task&view_type=form&menu_id=4720
Pad : https://pad.odoo.com/p/r.4a2ab8eb6b0043ccd278748e050f733a
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr