Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale: send sample #32443

Closed

Conversation

nim-odoo
Copy link
Contributor

@nim-odoo nim-odoo commented Apr 5, 2019

In a multi-company / multi-currency / multi-pricelist environment,
sending the sample SO may crash because the company_id field on the SO
line is not yet defined when a price conversion is necessary.

This is because it is a stored related field used in product_id_change
which is called programmatically at creation.

opw-1948629

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

In a multi-company / multi-currency / multi-pricelist environment,
sending the sample SO may crash because the `company_id` field on the SO
line is not yet defined when a price conversion is necessary.

This is because it is a stored related field used in `product_id_change`
which is called programmatically at creation.

opw-1948629
@nim-odoo nim-odoo self-assigned this Apr 5, 2019
@nim-odoo nim-odoo added the OE the report is linked to a support ticket (opw-...) label Apr 5, 2019
@nim-odoo
Copy link
Contributor Author

nim-odoo commented Apr 5, 2019

robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Apr 5, 2019
@robodoo robodoo closed this in 6e1170b Apr 5, 2019
@robodoo
Copy link
Contributor

robodoo commented Apr 5, 2019

Merged, thanks!

@nim-odoo nim-odoo deleted the 12.0-opw-1948629-send_sample-nim branch April 5, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants