[IMP] account: Adding a method to check reconcilability on bank statements

[hbto]

[IMP] account: Adding a method to check reconcilability on
account.bank.statement.line and make it inheritable.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[moylop260]

@nim-odoo
It looks more inheritable
We need to add custom validations here then it could be good if it is applied this patch then we can apply our custom behaviour.

What do you think?

[moylop260]

@nim-odoo
Could you help us to check it, please?

[nim-odoo]

What is the use case you are trying to solve?

By the way, counterpart_aml_dicts, payment_aml_rec and new_aml_dicts could also be sent to the method. So that it receives all available information to extend the behavior.

[hbto]

@nim-odoo

What is the use case you are trying to solve?

Users want to add validations at the reconciliation of Journal Items of future or past dates than that of the Bank Statement Line date.

By adding this method it will be possible to add those validations without having to override the whole method.

Regards.

[nim-odoo]

I don't think this is in any way necessary. You can do:

def process_reconciliation(self, counterpart_aml_dicts=None, payment_aml_rec=None, new_aml_dicts=None):
    for rec in payment_aml_rec or self.env['account.move.line']:
        [do whatever check you want here]
    super().process_reconciliation(counterpart_aml_dicts, payment_aml_rec, new_aml_dicts)

No valuable information is computed before the piece of code you want to override, only a couple of variable assignments. Making this inheritable won't make an override cleaner or easier.

[mart-e]

Closing following the reasons given by Nicolas.