Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] purchase: real time average multicurrency valuation #32616

Closed
wants to merge 1 commit into from

Conversation

kebeclibre
Copy link
Contributor

Do a PO in a foreign currency
Invoice it in the same foreign currency
Validate the invoice

Before this commit, The account move of the invoice
contained a price difference line
which is wrong, since the price has not changed in any ways

After this commit, the move has only two lines
one in the stock input, one in the payable

Also, the case where the price does change
due to a change in currency rate is handled

OPW 1955315

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@kebeclibre
Copy link
Contributor Author

"Forward Port" of #32180
Because in saas-11.3 the accounting precision is finer:
we post exchange difference in the relevant accounting journal, and not in the price diff account

@kebeclibre kebeclibre changed the base branch from 12.0 to saas-11.3 April 11, 2019 07:50
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 11, 2019
Do a PO in a foreign currency
Invoice it in the same foreign currency
Validate the invoice

Before this commit, The account move of the invoice
contained a price difference line
which is wrong, since the price has not changed in any ways

After this commit, the move has only two lines
one in the stock input, one in the payable

Also, the case where the price does change
due to a change in currency rate is handled

OPW 1955315
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 11, 2019
@nim-odoo
Copy link
Contributor

"Forward Port" of #32180
Because in saas-11.3 the accounting precision is finer:
we post exchange difference in the relevant accounting journal, and not in the price diff account

Does it mean that #32180 shouldn't be forward-ported at all?

@kebeclibre
Copy link
Contributor Author

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 16, 2019
Do a PO in a foreign currency
Invoice it in the same foreign currency
Validate the invoice

Before this commit, The account move of the invoice
contained a price difference line
which is wrong, since the price has not changed in any ways

After this commit, the move has only two lines
one in the stock input, one in the payable

Also, the case where the price does change
due to a change in currency rate is handled

OPW 1955315

closes #32616

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 16, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 16, 2019
@fw-bot fw-bot deleted the saas-11.3-stock-valo-lpe branch October 19, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants