[IMP] sms, sms_*: sms composer and templates #32625

pro-odoo · 2019-04-11T11:26:44Z

The aim of this commit is to:

Add templates for SMS:

Users can now create template for SMS Text messages similar to mail templates.
Templates can be linked with models, especially to create contextual action to quickly send SMS.

Improve the SMS composer:

Integrate the template system.
Allow to use it for mass SMS.

Handle SMS failures:

SMS is log in the chatter with a fa-comment icon next to the date.
The icon can be grey if all the SMS have correctly been sent.
The icon can be red if at least one SMS have not correctly been sent.
As mail, SMS failures are created if a SMS fails. The failure appears in the inbox.
When clicking on the red icon, a new modal is displayed, which is used to re-send SMS, discard SMS failures or buy more SMS credits.

Task ID: 1922163

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

addons/sms/static/src/xml/thread.xml

pro-odoo · 2019-04-24T07:13:40Z

@pimodoo I changed calendar_sms and hr_presence to work with SMS templates

addons/calendar_sms/models/calendar.py

dbeguin · 2019-05-13T15:27:09Z

addons/sms/models/sms_sms.py

+                record.write({
+                    'state': 'error',
+                    'error_code': 'insufficient_credit'
+                })


to reduce a bit the code, you could make something like this :

for record in self: error = 'missing_number' if not record.number else False if not error: number = record._get_sanitized_number() if not number: error = 'wrong_number_format' else: try: self.env['sms.api']._send_sms([number], record.content) except InsufficientCreditError: error = 'insufficient_credit' record.write({ 'state': 'error' if error else 'sent', 'error_code': error })

And I would prefer to name 'record' into 'sms', so we directly know what we are talking about :)
Same for all the other methods

The aim of this commit is to: 1) Add templates for SMS: - Users can now create template for SMS Text messages similar to mail templates. - Templates can be linked with models, especially to create contextual action to quickly send SMS. 2) Improve the SMS composer: - Integrate the template system. - Allow to use it for mass SMS. 3) Handle SMS failures: - SMS is log in the chatter with a fa-comment icon next to the date. - The icon can be grey if all the SMS have correctly been sent. - The icon can be red if at least one SMS have not correctly been sent. - As mail, SMS failures are created if a SMS fails. The failure appears in the inbox. - When clicking on the red icon, a new modal is displayed, which is used to re-send SMS, discard SMS failures or buy more SMS credits. Task ID: 1922163

pro-odoo · 2019-05-14T06:27:28Z

@dbeguin I made the change you suggested and rebased the branch :) Thanks for having a look !

dbeguin

Some remarks and questions

dbeguin · 2019-05-14T04:48:41Z

addons/sms/models/sms_sms.py

+                record.write({
+                    'state': 'error',
+                    'error_code': 'insufficient_credit'
+                })


And I would prefer to name 'record' into 'sms', so we directly know what we are talking about :)
Same for all the other methods

dbeguin · 2019-05-14T08:06:22Z

addons/sms/models/sms_sms.py

+        return recipients
+
+    @api.multi
+    def _get_sanitized_number(self):


Could be an opportunity to use that in voip enterprise stuff to avoid duplicated code (in a separated prepare commit with sms sanitization stuffs)

also, as for 'email_normalized' we could think of a 'number_sanitized' field, so we can directly use it in _send method

Ok for use it in enterprise, it was intended :)
But the field sanitized, I don't know... We should do one for mobile, one for phone, one for work mobile on employees, one for ... ;-)

dbeguin · 2019-05-14T08:30:52Z

addons/sms/models/mail_thread.py

+            to the mail.message
+            :param body: Note to log in the chatter.
+            :param sms_ids: IDs of the sms.sms records
+            :return: ID of the mail.message created


It's not the id that is returned but the message itself (even if main message_post docstring is incorrect). So I suggest to rename 'message_id' into 'message' (and maybe adapt the original docstring [in separated commit?])
also, is it not possible to integrate this into message_post directly ? so that the caller calls only message_post and the message post link itself the sms_ids to the message ? (giving sms_ids in kwargs)

Ok, what do you prefer ? override message_post ?

dbeguin · 2019-05-14T08:54:33Z

addons/sms/models/sms_api.py

+            'account_token': account.account_token,
+            'messages': messages
+        }
+        endpoint = self.env['ir.config_parameter'].sudo().get_param('sms.endpoint', DEFAULT_ENDPOINT) + '/iap/sms/1/send'


This '/iap/sms/1/send' is a route in odoo ?

It's in IAP

dbeguin · 2019-05-14T09:00:45Z

addons/sms/models/sms_api.py

@@ -12,9 +12,37 @@ class SmsApi(models.AbstractModel):
    _name = 'sms.api'
    _description = 'SMS API'

+    @api.model
+    def _send_multi_sms(self, messages):
+        """ Send SMS using IAP in batch mode


I think this should be the role of this method to prepare the parameters. I would give sms.sms instead of messages list of dict as sms.sms model contains everything you need.

It was for the possibility to only send sms, without creating sms.sms

dbeguin · 2019-05-14T09:15:37Z

addons/sms/wizard/sms_compose_message.py

+        if self.env.context.get('default_composition_mode') != 'mass_sms' \
+            and not self.env.context.get('default_recipient_ids'):
+            recipients = self.env['sms.sms']._get_sms_recipients(active_model, records.id)
+            missing_numbers = []


missing_numbers = [recipient['partner_id'].display_name for recipient in recipients if not recipient['number']]

robodoo added the seen 🙂 label Apr 11, 2019

pro-odoo force-pushed the master-sms-template-pro branch from 5d55dce to 4b4f38b Compare April 11, 2019 11:35

C3POdoo added the RD research & development, internal work label Apr 11, 2019

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 11, 2019

pro-odoo force-pushed the master-sms-template-pro branch from bfc9839 to 834d5d3 Compare April 12, 2019 13:26

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 12, 2019

pro-odoo force-pushed the master-sms-template-pro branch 4 times, most recently from ccf82e4 to bea169e Compare April 16, 2019 08:10

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 16, 2019

pro-odoo force-pushed the master-sms-template-pro branch from 218254b to ad2b8b9 Compare April 23, 2019 12:53

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 23, 2019

pro-odoo requested a review from pimodoo April 23, 2019 13:09

pimodoo reviewed Apr 23, 2019

View reviewed changes

addons/sms/static/src/xml/thread.xml Outdated Show resolved Hide resolved

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 23, 2019

robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2019

pimodoo reviewed Apr 25, 2019

View reviewed changes

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 25, 2019

pro-odoo force-pushed the master-sms-template-pro branch from 8ab5076 to 874ef22 Compare April 26, 2019 07:01

robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 26, 2019

pro-odoo force-pushed the master-sms-template-pro branch from 874ef22 to 394a7ae Compare April 26, 2019 09:10

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 26, 2019

pro-odoo force-pushed the master-sms-template-pro branch from 33dbf95 to 12bbe4f Compare May 2, 2019 11:57

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 2, 2019

pro-odoo force-pushed the master-sms-template-pro branch from 2aeac0e to cb057b6 Compare May 9, 2019 11:58

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels May 9, 2019

dbeguin reviewed May 13, 2019

View reviewed changes

pro-odoo added 3 commits May 14, 2019 08:25

[IMP] calendar_sms: use sms template

e7eb3fb

[IMP] hr_presence: use sms template

cf91e6e

pro-odoo force-pushed the master-sms-template-pro branch from 39e47b5 to cf91e6e Compare May 14, 2019 06:26

robodoo removed the CI 🤖 Robodoo has seen passing statuses label May 14, 2019

robodoo added the CI 🤖 Robodoo has seen passing statuses label May 14, 2019

dbeguin reviewed May 14, 2019

View reviewed changes

pro-odoo closed this Oct 7, 2019

robodoo added closed 💔 and removed CI 🤖 Robodoo has seen passing statuses labels Oct 7, 2019

pro-odoo deleted the master-sms-template-pro branch October 14, 2019 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] sms, sms_*: sms composer and templates #32625

[IMP] sms, sms_*: sms composer and templates #32625

pro-odoo commented Apr 11, 2019 •

edited

Loading

pro-odoo commented Apr 24, 2019

dbeguin May 13, 2019

dbeguin May 14, 2019

pro-odoo commented May 14, 2019

dbeguin left a comment

dbeguin May 14, 2019

dbeguin May 14, 2019

dbeguin May 14, 2019

pro-odoo May 14, 2019

dbeguin May 14, 2019

pro-odoo May 14, 2019

dbeguin May 14, 2019

pro-odoo May 14, 2019

dbeguin May 14, 2019

pro-odoo May 14, 2019

dbeguin May 14, 2019

[IMP] sms, sms_*: sms composer and templates #32625

[IMP] sms, sms_*: sms composer and templates #32625

Conversation

pro-odoo commented Apr 11, 2019 • edited Loading

pro-odoo commented Apr 24, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pro-odoo commented May 14, 2019

dbeguin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pro-odoo commented Apr 11, 2019 •

edited

Loading