[FIX] packaging: avoid jinja2 asyncsupport in py2exe #32913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that it should fix the build problem. So the compiled exe should be able to run without the assyncsupport. |
odony
reviewed
Apr 24, 2019
|
As 11.0 does not use py2exe, I already removed the py2exe code here : 055e1b8 |
Since 78ba90d, when building the windows package, py2exe fails to compiles jinja2 asyncsupport module. Even tough jinja detects the environement, py2exe tries to compile the async part. The problem comes from the fact that async keyword was introduced in python 3 and we use py2exe with python 2.7. With this commit the async part of jinja is execluded from py2exe.
d-fence
force-pushed
the
10.0-fix-jinja2-p2exe-moc
branch
from
4074f65
to
4ed07fa
Compare
robodoo
added
CI 🤖
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2019
Since 78ba90d, when building the windows package, py2exe fails to compiles jinja2 asyncsupport module. Even tough jinja detects the environement, py2exe tries to compile the async part. The problem comes from the fact that async keyword was introduced in python 3 and we use py2exe with python 2.7. With this commit the async part of jinja is execluded from py2exe. closes #32913 Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
|
Staging failed: ci/runbot on 31bc88f82275ecb1519bacf9f2fdd432e7ebb9b8 (view more at http://runbot.odoo.com/runbot/build/507469) |
|
@robodoo retry |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 78ba90d, when building the windows package, py2exe fails to
compile jinja2 asyncsupport module. Even tough jinja detects the
environement, py2exe tries to compile the async part. The problem comes
from the fact that async keyword was introduced in python 3 and we use
py2exe with python 2.7.
With this commit the async part of jinja is execluded from py2exe.