[FIX] base: restore address display alignments #34371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit odoo@0c6e0d6 used flex to properly align address information and the fa icons. The problem is that using flex prevents the parent div to ask for the address information to be center/right aligned. This is the case for the job pages in internal. This commit uses display: inline-block on the top-level element of the address to solve the problem. opw-2000947
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 26, 2019
Commit 0c6e0d6 used flex to properly align address information and the fa icons. The problem is that using flex prevents the parent div to ask for the address information to be center/right aligned. This is the case for the job pages in internal. This commit uses display: inline-block on the top-level element of the address to solve the problem. opw-2000947 closes #34371 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
added
CI 🤖
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0c6e0d6
used flex to properly align address information and the fa icons. The
problem is that using flex prevents the parent div to ask for the
address information to be center/right aligned. This is the case for
the job pages in internal.
This commit uses display: inline-block on the top-level element of the
address to solve the problem.
opw-2000947