[IMP] hr_expense: usability improvements #35400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
4bc3daf
to
9ed3540
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
9ed3540
to
2366b3c
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
2366b3c
to
66fac0b
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
66fac0b
to
8439cc6
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
8439cc6
to
16b6eb7
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
16b6eb7
to
4f58d3a
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
4f58d3a
to
32ae0da
Compare
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
32ae0da
to
80cd2a2
Compare
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
80cd2a2
to
d56e555
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
d56e555
to
762f051
Compare
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
762f051
to
e851d8d
Compare
robodoo
added
CI 🤖
tivisse
requested changes
Aug 13, 2019
| @@ -156,6 +156,42 @@ def _onchange_product_uom_id(self): | |||
| if self.product_id and self.product_uom_id.category_id != self.product_id.uom_id.category_id: | |||
| raise UserError(_('Selected Unit of Measure does not belong to the same category as the product Unit of Measure.')) | |||
|
|
|||
| def create_expense_from_attachments(self, attachment_ids=[]): | |||
There was a problem hiding this comment.
1/ Did you consider the security ? You have a public method to create attachments from an arbitrary list of ids.
2/ You should never use a mutable object as a method parameter. See: https://www.tutorialdocs.com/article/9-worst-python-practices.html
There was a problem hiding this comment.
@tivisse
For point 1: I have put a condition, in that I have checked res_id and res_model values. If condition will be true then only 'create' will execute and records will be created.
For point 2: changes are done !
| var qweb = core.qweb; | ||
| var DocumentUploadMixin = { | ||
|
|
||
| start: function () { |
There was a problem hiding this comment.
Could you adapt the code to:
- Match the odoo guidelines
- Match the linter requirements
Thanks.
| }); | ||
|
|
||
| odoo.define('hr_expense.expenses.tree', function (require) { | ||
| "use strict"; |
There was a problem hiding this comment.
Should be split into 2 .js files.
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
e851d8d
to
e7a8907
Compare
robodoo
added
CI 🤖
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
e7a8907
to
ccba1f2
Compare
sht-odoo
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
ccba1f2
to
041b3f6
Compare
For better user experience, there should be a 'UPLOAD' button on'hr.expense' through which user can directly upload a single or multiple documents and according to the number of documents, blank expense record with attached document should be generated. These records should be in 'draft' state. TaskID: 2040887
tivisse
force-pushed
the
master-hr_expense-usability-improvement-sht
branch
from
041b3f6
to
86dc991
Compare
|
@robodoo r+ |
robodoo
added
r+ 👌
CI 🤖
robodoo
pushed a commit
that referenced
this pull request
Aug 16, 2019
For better user experience, there should be a 'UPLOAD' button on'hr.expense' through which user can directly upload a single or multiple documents and according to the number of documents, blank expense record with attached document should be generated. These records should be in 'draft' state. TaskID: 2040887 closes #35400 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
|
Merged at bf347e7, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task - https://www.odoo.com/web?#id=2040887&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
pad - https://pad.odoo.com/p/r.a4335d455e929d48a75746eb6a62411d
For better user experience, there should be a 'UPLOAD' button on hr.expense
through which user can directly upload a single or multiple documents and
according to the number of documents, blank expense record with attached
document should be generated. These records should be in 'draft' state.
By this commit, this improvement has been achieved.