[FIX] *: remove buggy calls to with_context #36692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When .with_context() is called with a dictionary as 1st positional argument, it will replace context (and not modify the referenced keys) It may create bugs when losing the content of the context (e.g. remove partner's language) This is a partial backport of odoo#36164 with the website part as discussed.
|
Forward-porting to 'saas-11.3'. |
robodoo
pushed a commit
that referenced
this pull request
Sep 11, 2019
When .with_context() is called with a dictionary as 1st positional argument, it will replace context (and not modify the referenced keys) It may create bugs when losing the content of the context (e.g. remove partner's language) This is a partial backport of #36164 with the website part as discussed. closes #36692 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
Merged at 921f5ff, thanks! |
mart-e
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 11, 2019
When .with_context() is called with a dictionary as 1st positional argument, it will replace context (and not modify the referenced keys) It may create bugs when losing the content of the context (e.g. remove partner's language) This is a partial backport of odoo#36164 with the website part as discussed. closes odoo#36692 X-Origin: 921f5ff Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 11, 2019
When .with_context() is called with a dictionary as 1st positional argument, it will replace context (and not modify the referenced keys) It may create bugs when losing the content of the context (e.g. remove partner's language) This is a partial backport of #36164 with the website part as discussed. closes #36692 closes #36700 X-origin: 921f5ff Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When .with_context() is called with a dictionary as 1st positional
argument, it will replace context (and not modify the referenced keys)
It may create bugs when losing the content of the context (e.g. remove
partner's language)
This is a partial backport of #36164 of @yajo with the website part as
discussed with @JKE-be