[IMP] sale qweb report: add names to columns for better inheritance #37769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dbo-odoo this is something you could help please? Thanks |
mart-e
force-pushed
the
13.0-improve-sale-report-inheritance
branch
from
d8d4469
to
62114b1
Compare
|
Rebased and squash, thanks ! @robodoo r+ |
|
@chienandalu stock and purchase will require the same |
robodoo
pushed a commit
that referenced
this pull request
Oct 2, 2019
closes #37769 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
Merged at 93157eb, thanks! |
Tardo
pushed a commit
to Tecnativa/odoo
that referenced
this pull request
Jan 21, 2020
closes odoo#37769 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases is hard to have a deterministic inheritance of qweb reports like this from the sale module.
This patch just adds to table headers
<th>and table datas<td>a unique name to easily hook by xpath.cc @Tecnativa
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr