Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master sale generate link arj #38287

Closed
wants to merge 2 commits into from

Conversation

@arj-odoo
Copy link
Contributor

commented Oct 9, 2019

[IMP] web: CopyClipboardCharLong widget for long strings

 - The copy CopyClipboardChar widget is not nicely rendered for very long strings (e.g. URL).
 - This commit modify the behavior of the CopyClipboardChar widget to display it nicely win such cases.

TaskID: 2059972

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Oct 9, 2019
@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from 57ea35d to 5df94e3 Oct 9, 2019
@C3POdoo C3POdoo added the RD label Oct 9, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 9, 2019
@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from 288e5b8 to 08b1a5b Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from 08b1a5b to fc5dec0 Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from fc5dec0 to 6acd6f0 Oct 11, 2019
@robodoo robodoo removed the CI 🤖 label Oct 11, 2019
@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from 6acd6f0 to 274ee84 Oct 11, 2019
@robodoo robodoo added the CI 🤖 label Oct 11, 2019
@arj-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

@VincentSchippefilt I modified the code to modify the default behavior of the CopyClipboardChar widget. I did not observed any bug in other modules where these widgets are used (CopyClipboardChar and CopyClipboardtext).

@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from 274ee84 to 2f59103 Oct 11, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 11, 2019
Copy link
Contributor

left a comment

Commit should be [IMP] web: ...

this._super.apply(this, arguments);
if (this.value) {
this.$el.append($(qweb.render(this.clipboardTemplate)));
this.$el.addClass('o_text_overflow');

This comment has been minimized.

Copy link
@VincentSchippefilt

VincentSchippefilt Oct 11, 2019

Contributor

this should be added in the template

 - The copy CopyClipboardChar widget is not nicely rendered for very long strings (e.g. URL).
 - This commit modify the behavior of the CopyClipboardChar widget to display it nicely win such cases.

TaskID: 2059972
@arj-odoo arj-odoo force-pushed the odoo-dev:master-sale-generate_link-arj branch from 2f59103 to 3ca0d99 Oct 11, 2019
@robodoo robodoo removed the CI 🤖 label Oct 11, 2019
payment_ref and amount are small fields that does not render well in large fields.

TaskID: 2059972
@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

robodoo rebase-ff

@VincentSchippefilt VincentSchippefilt self-requested a review Oct 11, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 label Oct 11, 2019
@arj-odoo arj-odoo requested a review from dbo-odoo Oct 15, 2019
@dbo-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2019

@robodoo robodoo added the r+ 👌 label Oct 15, 2019
robodoo pushed a commit that referenced this pull request Oct 15, 2019
payment_ref and amount are small fields that does not render well in large fields.

closes #38287

Taskid: 2059972
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2019

Merged at 8578518, thanks!

@robodoo robodoo closed this Oct 15, 2019
@arj-odoo arj-odoo deleted the odoo-dev:master-sale-generate_link-arj branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.