Master sale generate link arj #38287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
57ea35d
to
5df94e3
Compare
robodoo
added
CI 🤖
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
288e5b8
to
08b1a5b
Compare
robodoo
added
CI 🤖
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
08b1a5b
to
fc5dec0
Compare
robodoo
added
CI 🤖
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
fc5dec0
to
6acd6f0
Compare
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
6acd6f0
to
274ee84
Compare
|
@VincentSchippefilt I modified the code to modify the default behavior of the CopyClipboardChar widget. I did not observed any bug in other modules where these widgets are used (CopyClipboardChar and CopyClipboardtext). |
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
274ee84
to
2f59103
Compare
robodoo
added
CI 🤖
VincentSchippefilt
requested changes
Oct 11, 2019
| this._super.apply(this, arguments); | ||
| if (this.value) { | ||
| this.$el.append($(qweb.render(this.clipboardTemplate))); | ||
| this.$el.addClass('o_text_overflow'); |
There was a problem hiding this comment.
this should be added in the template
- The copy CopyClipboardChar widget is not nicely rendered for very long strings (e.g. URL). - This commit modify the behavior of the CopyClipboardChar widget to display it nicely win such cases. TaskID: 2059972
arj-odoo
force-pushed
the
master-sale-generate_link-arj
branch
from
2f59103
to
3ca0d99
Compare
payment_ref and amount are small fields that does not render well in large fields. TaskID: 2059972
|
robodoo rebase-ff |
VincentSchippefilt
approved these changes
Oct 11, 2019
|
Merge method set to rebase and fast-forward |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 15, 2019
payment_ref and amount are small fields that does not render well in large fields. closes #38287 Taskid: 2059972 Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
|
Merged at 8578518, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskID: 2059972
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr