Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] survey: missing questions without section in survey #39064

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Oct 18, 2019

Since commit dba4783, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.

This prevents to display some questions of a survey, as we are
still expecting a structure page/questions. To solve it, we first
append questions with no sections, then all other questions.

Description of the issue/feature this PR addresses:
opw-2089932

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #39015

@fw-bot
Copy link
Contributor Author

fw-bot commented Oct 18, 2019

Ping @alt-odoo, @rim-odoo
Cherrypicking b8dca55 of source #39015 failed

stderr:

error: could not apply b8dca55535e... [FIX] survey: missing questions without section in survey
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
Recorded preimage for 'addons/survey/models/survey_survey.py'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@robodoo robodoo added seen 🙂 conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Oct 18, 2019
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Oct 18, 2019
Since commit odoo@dba4783, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.

This prevents to display some questions of a survey, as we are
still expecting a structure page/questions. To solve it, we first
append questions with no sections, then all other questions.
@alt-odoo alt-odoo force-pushed the 13.0-saas-12.3-missing-questions-without-section-alt-Mn78-fw branch from 8f379b4 to 340e989 Compare October 21, 2019 07:56
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Oct 21, 2019
@alt-odoo
Copy link
Contributor

@rim-odoo

Conflict of this forward PR is solved, but manual restart is needed.
Can you merge it please?

@rim-odoo
Copy link
Contributor

@robodoo r+

C'est la chenille qui redémarre @alt-odoo

@robodoo
Copy link
Contributor

robodoo commented Oct 21, 2019

Merged at 149657c, thanks!

@fw-bot fw-bot deleted the 13.0-saas-12.3-missing-questions-without-section-alt-Mn78-fw branch November 4, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants