[FW][FIX] website_sale: removing invalid product from the cart #40241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce the issue: - Install eCommerce app - Publish a product to your website - Add the product in your cart - Unpublish/make unsellable/archive the product The product is still in the cart and the checkout process can be done. Cause: There is no check for invalid products before displaying the cart This commit remove the invalid products while loading the cart. OPW-2092541 X-original-commit: ab9290e
|
Ping @jasonvanmalder, @nim-odoo To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
|
@nim-odoo Can you robodoo retry, please? Thanks! |
robodoo
pushed a commit
that referenced
this pull request
Nov 26, 2019
Reproduce the issue: - Install eCommerce app - Publish a product to your website - Add the product in your cart - Unpublish/make unsellable/archive the product The product is still in the cart and the checkout process can be done. Cause: There is no check for invalid products before displaying the cart This commit remove the invalid products while loading the cart. OPW-2092541 closes #40241 X-original-commit: ab9290e Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
fw-bot
deleted the
master-12.0-opw-2092541-fix-ecommerce_cart_archived_unpublished_unsellable_product-jvm-4tNe-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce the issue:
The product is still in the cart and the checkout process can be done.
Cause: There is no check for invalid products before displaying the cart
This commit remove the invalid products while loading the cart.
OPW-2092541
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #40168
Forward-Port-Of: #39931