-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] mass_mailing: can unsubscribe in multidomain #42852
Closed
fw-bot
wants to merge
1
commit into
odoo:saas-11.3
from
odoo-dev:saas-11.3-11.0-mass-mailing-opw-2124890-nle-ylg9-fw
Closed
[FW][FIX] mass_mailing: can unsubscribe in multidomain #42852
fw-bot
wants to merge
1
commit into
odoo:saas-11.3
from
odoo-dev:saas-11.3-11.0-mass-mailing-opw-2124890-nle-ylg9-fw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping @nle-odoo stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
seen 🙂
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
labels
Jan 7, 2020
nle-odoo
force-pushed
the
saas-11.3-11.0-mass-mailing-opw-2124890-nle-ylg9-fw
branch
2 times, most recently
from
January 7, 2020 13:33
8d419bd
to
348b6b4
Compare
should be fixed, I will just test on runbot before merging |
The `unsubscribe` feature of mass mailings repose on having a link with HREF attribute `/unsubscribe_from_list` inside the mail message. When the mass mailing is sent: - relative URL are replaced by absolute URL (`/unsubscribe_from_list` is replaced by `{system parameter web.base.url}/unsubscribe_from_list`) - `{system parameter web.base.url}/unsubscribe_from_list` is replaced by the real mass mailing link containing info that will be used to unsubscribe the user. But there was an issue in the case of multiple domain, if this scenario happened: - system parameter web.base.url is http://domain1 - a user use "Test" button on a mass mailing - system parameter web.base.url becomes http://domain2 - the mass mailing is sent The unsubscribe link is broken, this is because the implementation of "Test Mailing" feature would update the mass mailing with absolute links, so if the domain change, we the `unsubscribe` link will no longer be found and replaced into the source. opw-2124890 closes odoo#42373 X-original-commit: fccf20b
nle-odoo
force-pushed
the
saas-11.3-11.0-mass-mailing-opw-2124890-nle-ylg9-fw
branch
from
January 14, 2020 10:04
348b6b4
to
57db840
Compare
robodoo
added
CI 🤖
Robodoo has seen passing statuses
and removed
CI 🤖
Robodoo has seen passing statuses
labels
Jan 14, 2020
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 14, 2020
The `unsubscribe` feature of mass mailings repose on having a link with HREF attribute `/unsubscribe_from_list` inside the mail message. When the mass mailing is sent: - relative URL are replaced by absolute URL (`/unsubscribe_from_list` is replaced by `{system parameter web.base.url}/unsubscribe_from_list`) - `{system parameter web.base.url}/unsubscribe_from_list` is replaced by the real mass mailing link containing info that will be used to unsubscribe the user. But there was an issue in the case of multiple domain, if this scenario happened: - system parameter web.base.url is http://domain1 - a user use "Test" button on a mass mailing - system parameter web.base.url becomes http://domain2 - the mass mailing is sent The unsubscribe link is broken, this is because the implementation of "Test Mailing" feature would update the mass mailing with absolute links, so if the domain change, we the `unsubscribe` link will no longer be found and replaced into the source. opw-2124890 closes #42373 closes #42852 X-original-commit: fccf20b Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
fw-bot
deleted the
saas-11.3-11.0-mass-mailing-opw-2124890-nle-ylg9-fw
branch
January 28, 2020 12:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI 🤖
Robodoo has seen passing statuses
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
OE
the report is linked to a support ticket (opw-...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unsubscribe
feature of mass mailings repose on having a link withHREF attribute
/unsubscribe_from_list
inside the mail message.When the mass mailing is sent:
relative URL are replaced by absolute URL (
/unsubscribe_from_list
isreplaced by
{system parameter web.base.url}/unsubscribe_from_list
){system parameter web.base.url}/unsubscribe_from_list
is replaced bythe real mass mailing link containing info that will be used to
unsubscribe the user.
But there was an issue in the case of multiple domain, if this scenario
happened:
The unsubscribe link is broken, this is because the implementation of
"Test Mailing" feature would update the mass mailing with absolute
links, so if the domain change, we the
unsubscribe
link is no longerfound and replaced into the source.
opw-2124890
Forward-Port-Of: #42373