Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] calendar: avoid creation of the document on invitation #43341

Closed
wants to merge 1 commit into from

Conversation

agr-odoo
Copy link
Contributor

Install Projects, documents, calendar, website, crm.
Under Settings enable "File Centralization"
Now go to Projects, enter in a Task, click on "schedule activity".
On the activity form under "Activity Type" choose Meeting, click on
"Open Calendar" button.
Choose a slot, edit the event, add a contact type individual, save
Error will popup.

This is caused by the whole flow of creating a new document for the
invitation.ics generated for the meetings which has to be sent via email
but get detected as an attachment to be sent into the document app as
well.

Disabling the document creation since it is not a relevant attachment

opw-2150770

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@agr-odoo
Copy link
Contributor Author

@nim-odoo

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Jan 15, 2020
@agr-odoo
Copy link
Contributor Author

agr-odoo commented Jan 15, 2020

Another idea was to actively filter out 'invitation.ics' here https://github.com/odoo/enterprise/blob/13.0/documents/models/ir_attachment.py#L125

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 15, 2020
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jan 16, 2020
@agr-odoo
Copy link
Contributor Author

@nim-odoo updated to avoid uncertainty in loop

Copy link
Contributor

@nim-odoo nim-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Jan 16, 2020

You may want to rebuild or fix this PR as it has failed CI.

@nim-odoo
Copy link
Contributor

robodoo r+

@nim-odoo
Copy link
Contributor

robodoo r+

@agr-odoo do not forget to regularly rebase your branches ;)

Install Projects, documents, calendar, website, crm.
Under Settings enable "File Centralization"
Now go to Projects, enter in a Task, click on "schedule activity".
On the activity form under "Activity Type" choose Meeting, click on
"Open Calendar" button.
Choose a slot, edit the event, add a contact type individual, save
Error will popup.

This is caused by the whole flow of creating a new document for the
invitation.ics generated for the meetings which has to be sent via email
but get detected as an attachment to be sent into the document app as
well.

Disabling the document creation since it is not a relevant attachment

opw-2150770
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 20, 2020
@agr-odoo
Copy link
Contributor Author

@nim-odoo finally ready :)

@nim-odoo
Copy link
Contributor

robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants