[FIX] mass_mailing, web_editor: edit font awesome icon with zoom #43949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nle-odoo
force-pushed
the
13.0-mass-mailing-web-editor-opw-2156069-nle
branch
from
a458394
to
d10de6a
Compare
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-awesome icon edition after first save by reverting the transformation to image on edit. Thanks to that, the original size will also be reinstated and will not depend on zoom on previous save. opw-2156069 closes odoo#43949
|
checked with chm, seems to make sense robodoo r+ |
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 27, 2020
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-awesome icon edition after first save by reverting the transformation to image on edit. Thanks to that, the original size will also be reinstated and will not depend on zoom on previous save. opw-2156069 closes odoo#43949 X-original-commit: fe72bf0
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 27, 2020
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-awesome icon edition after first save by reverting the transformation to image on edit. Thanks to that, the original size will also be reinstated and will not depend on zoom on previous save. opw-2156069 closes odoo#43949 X-original-commit: fe72bf0
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2020
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-awesome icon edition after first save by reverting the transformation to image on edit. Thanks to that, the original size will also be reinstated and will not depend on zoom on previous save. opw-2156069 closes #43949 closes #44030 X-original-commit: fe72bf0 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jan 31, 2020
In case of font-awesome icon when the browser is being zoomed, we can get a decimal font-size. There is a system that transform font-awesome in image links so they are readable in any email client (supporting image) but it did not take into account decimal font-size. With this changeset, we only send a integer font size: we do not try to get the original value because styling is relative on elements, a 90% zoom ratio could lead to a 98% font-awesome icon ratio. Also improve edition of font-awesome icon edition after first save by reverting the transformation to image on edit. Thanks to that, the original size will also be reinstated and will not depend on zoom on previous save. opw-2156069 closes #43949 closes #44033 X-original-commit: fe72bf0 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of font-awesome icon when the browser is being zoomed, we can
get a decimal font-size.
There is a system that transform font-awesome in image links so they are
readable in any email client (supporting image) but it did not take into
account decimal font-size.
With this changeset, we only send a integer font size: we do not try to
get the original value because styling is relative on elements, a 90%
zoom ratio could lead to a 98% font-awesome icon ratio.
Also improve edition of font-awesome icon edition after first save by
reverting the transformation to image on edit. Thanks to that, the
original size will also be reinstated and will not depend on zoom on
previous save.
opw-2156069