Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website(_crm): fix email and phone computation of visitor #48369

Closed

Commits on Mar 25, 2020

  1. [FIX] website(_crm): fix email and phone computation of visitor

    Currently there are several limitations in visitor email and phone
    computation, notably phone of partner is not taken into account (only mobile)
    and computation does not work in website_crm if there are no leads.
    
    In this commit we
    
      * support both mobile and phone fields of partner. Indeed generally all
        SMS flows check for those two fields and not only for mobile;
      * replace the SQL by standard ORM computation. As those fields are not stored
        and displayed in list views ORM should be capable of managing them;
      * avoid crash when creating visitors through the UI (no ids -> don't go
        into raw SQL);
      * correctly keep partner-based values when no lead is linked to the visitor;
    
    Tests are also added in order to ensure behavior.
    
    Task ID 2196869
    
    X-original-commit: 02ceb42
    tde-banana-odoo committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    df5d1b5 View commit details
    Browse the repository at this point in the history