[FW][FIX] point_of_sale: do not reconcile 0 sum lines #48799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Have a clean V13 db with point_of_sale and account_accountant - General Settings => Accounting => Check "Anglo-Saxon Accounting" (debug mode) - Choose or create a storable product P with category C - Go to category C and set 'inventory valuation' to 'automated' - Open a new POS session PS - Sell product P with qty 1 - Pay - New order - Sell product P with qty -1 (refund) - Pay - Close session PS - Validate session PS Error "You are trying to reconcile some entries that are already reconciled." will popup because the 0 sum AML is already marked as reconciled. This can be fixed by avoiding asking reconciliation when the amount_residual is 0. opw-2177881 X-original-commit: 2c5ef4e
|
Ping @agr-odoo, @nim-odoo
To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 2, 2020
- Have a clean V13 db with point_of_sale and account_accountant - General Settings => Accounting => Check "Anglo-Saxon Accounting" (debug mode) - Choose or create a storable product P with category C - Go to category C and set 'inventory valuation' to 'automated' - Open a new POS session PS - Sell product P with qty 1 - Pay - New order - Sell product P with qty -1 (refund) - Pay - Close session PS - Validate session PS Error "You are trying to reconcile some entries that are already reconciled." will popup because the 0 sum AML is already marked as reconciled. This can be fixed by avoiding asking reconciliation when the amount_residual is 0. opw-2177881 closes #48799 X-original-commit: 2c5ef4e Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(debug mode)
Error "You are trying to reconcile some entries that are already
reconciled." will popup because the 0 sum AML is already marked as
reconciled. This can be fixed by avoiding asking reconciliation when the
amount_residual is 0.
opw-2177881
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #48696