Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] base: show module in translation tree #55649

Closed
wants to merge 1 commit into from

Conversation

yostashiro
Copy link
Contributor

@yostashiro yostashiro commented Aug 8, 2020

Description of the issue/feature this PR addresses:

It is a little inconvenient as a translator not to see the module in translation tree...

@qrtl

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses and removed ☐ legal/cla labels Aug 8, 2020
@Yenthe666
Copy link
Collaborator

@mart-e

@mart-e
Copy link
Contributor

mart-e commented Aug 10, 2020

Hi,

Why adding base.group_no_one ? This view is already for technical users only.

@robodoo robodoo added ☐ ci/runbot and removed CI 🤖 Robodoo has seen passing statuses ☑ ci/runbot labels Aug 10, 2020
@yostashiro
Copy link
Contributor Author

Why adding base.group_no_one ? This view is already for technical users only.

@mart-e That was because the field in the form view had the group assigned and I was trying to make the update consistent. But you are right. The group assignment is redundant, and I have removed the group from the field.

Useful information to identify where a translation comes from
Remove base.group_no_one as the view is already in debug only and
technical
Copy link
Contributor

@mart-e mart-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's a good addition
@robodoo r+

@@ -33,7 +34,7 @@
<field name="lang"/>
</group>
<group>
<field name="module" groups="base.group_no_one"/>
<field name="module"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this view is no longer used anyway so we should probably get rid of it in the future...

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses and removed ☐ legal/cla labels Aug 10, 2020
robodoo pushed a commit that referenced this pull request Aug 10, 2020
Useful information to identify where a translation comes from
Remove base.group_no_one as the view is already in debug only and
technical

closes #55649

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
@robodoo robodoo closed this Aug 10, 2020
@robodoo robodoo temporarily deployed to merge August 10, 2020 12:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants