[FIX] website_rating: display correct title and tooltip on star #60633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
CI 🤖
Title and tooltip had no sense since every star would have its own tooltip "One star" instead of having a single tooltip on the whole star container which could show the exact rating "5 stars on 5". Plus, one of the title were set on a t-foreach which does nothing. Closes odoo#51743 task-2369420
rdeodoo
force-pushed
the
13.0-fix-star-tooltip-rde
branch
from
9241194
to
0d8a688
Compare
robodoo
added
☐ ci/runbot
and removed
CI 🤖
robodoo
added
☑ ci/security
CI 🤖
|
@JKE-be Reminder, this one is still good to me, I checked about the potential rounding errors but everything seems fine on my end due to the rounding performed in JS |
|
@robodoo r+ Replace |
robodoo
pushed a commit
that referenced
this pull request
Nov 12, 2020
Title and tooltip had no sense since every star would have its own tooltip "One star" instead of having a single tooltip on the whole star container which could show the exact rating "5 stars on 5". Plus, one of the title were set on a t-foreach which does nothing. Closes #51743 task-2369420 closes #60633 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
This was referenced Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title and tooltip had no sense since every star would have its own tooltip
"One star" instead of having a single tooltip on the whole star container which
could show the exact rating "5 stars on 5".
Plus, one of the title were set on a t-foreach which does nothing.
Closes #51743
task-2369420