[IMP] website_sale: faster recursive e-commerce category search #60834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
12.0-website_sale-faster_recursive_categories
branch
from
e7e85f1
to
e16551d
Compare
robodoo
added
☑ ci/security
CI 🤖
|
@JKE-be what do you think about this? |
When a website has a big category tree, without this patch it has to make a lot of queries just to build the tree. Now it's way faster because it solves all in 1 query. For example, in a production database, and after warmup, this reduced the amount of queries from 369 to 229 while browsing a category. That's 140 less queries, a lot. Also, when browsing `/shop`, it reduced the queries from 326 to 172. The times inside and outside Postgres also improve according to my tests. Note: this domain could be even more constrained to avoid reading all website categories if they are collapsed, but given odoo#34249 is not in v12, it ends up producing lots of more queries (by using `child_of` or `parent_of` operators) and slowing more the result than just downloading all of them. @Tecnativa TT26309
yajo
force-pushed
the
12.0-website_sale-faster_recursive_categories
branch
from
e16551d
to
ec08a9c
Compare
robodoo
added
☐ ci/runbot
and removed
CI 🤖
robodoo
added
☐ ci/style
CI 🤖
|
Didn't check the PR yet but for informative purpose, this was improved in later version with 5f87def |
|
As explain by @rdeodoo it has been already improved in v13. |
eLBati
added a commit
to takobi-online/odoo
that referenced
this pull request
May 22, 2023
…make a lot of queries just to build the tree. Now it's way faster because it solves all in 1 query. For example, in a production database, and after warmup, this reduced the amount of queries from 369 to 229 while browsing a category. That's 140 less queries, a lot. Also, when browsing /shop, it reduced the queries from 326 to 172. The times inside and outside Postgres also improve according to my tests. Note: this domain could be even more constrained to avoid reading all website categories if they are collapsed, but given faed8d5 is not in v12, it ends up producing lots of more queries (by using child_of or parent_of operators) and slowing more the result than just downloading all of them odoo#60834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a website has a big category tree, without this patch it has to make a lot of queries just to build the tree. Now it's way faster because it solves all in 1 query.
For example, in a production database, and after warmup, this reduced the amount of queries from 369 to 229 while browsing a category. That's 140 less queries, a lot. Also, when browsing
/shop, it reduced the queries from 326 to 172. The times inside and outside Postgres also improve according to my tests.Note: this domain could be even more constrained to avoid reading all website categories if they are collapsed, but given faed8d5 is not in v12, it ends up producing lots of more queries (by using
child_oforparent_ofoperators) and slowing more the result than just downloading all of them.@Tecnativa TT26309
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr