-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] event: ignore fields which have a default value #69939
Closed
fw-bot
wants to merge
2
commits into
odoo:saas-11.3
from
odoo-dev:saas-11.3-11.0-registration-tde-WK8A-fw
Closed
[FW][FIX] event: ignore fields which have a default value #69939
fw-bot
wants to merge
2
commits into
odoo:saas-11.3
from
odoo-dev:saas-11.3-11.0-registration-tde-WK8A-fw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
labels
Apr 27, 2021
Ping @tde-banana-odoo stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
Purpose ======= When creating an attendee from frontend some fields may be added in parameters, notably through inheritance (questions, ...). We want the defaults values to have the priority on those parameters (e.g. barcode code). Task ID-2322411 PR odoo#68699 X-Original-Commit: odoo/odoo@5391df9
tde-banana-odoo
force-pushed
the
saas-11.3-11.0-registration-tde-WK8A-fw
branch
from
April 27, 2021 14:39
1fa6cbb
to
16cdbd2
Compare
A computed field on event may crash if current user is a portal user as it tries to access registrations to know if current user is already participating to the event. We also fix ACL on the registrations as most code already use it as sudo and do not access it directly. Only the event users or admins should access it directly. Task ID-2322411 PR odoo#68699 X-Original-Commit: odoo/odoo@f7c95d9
tde-banana-odoo
force-pushed
the
saas-11.3-11.0-registration-tde-WK8A-fw
branch
from
April 27, 2021 14:40
16cdbd2
to
9d224fc
Compare
@fw-bot r+ |
@robodoo r+ rebase-ff |
robodoo
pushed a commit
that referenced
this pull request
Apr 28, 2021
A computed field on event may crash if current user is a portal user as it tries to access registrations to know if current user is already participating to the event. We also fix ACL on the registrations as most code already use it as sudo and do not access it directly. Only the event users or admins should access it directly. Task ID-2322411 PR #68699 closes #69939 X-original-commit: f7c95d9 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Merge method set to rebase and fast-forward |
tde-banana-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2021
A computed field on event may crash if current user is a portal user as it tries to access registrations to know if current user is already participating to the event. We also fix ACL on the registrations as most code already use it as sudo and do not access it directly. Only the event users or admins should access it directly. Task ID-2322411 PR odoo#68699 closes odoo#69939 X-original-commit: odoo/odoo@f7c95d9 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2021
A computed field on event may crash if current user is a portal user as it tries to access registrations to know if current user is already participating to the event. We also fix ACL on the registrations as most code already use it as sudo and do not access it directly. Only the event users or admins should access it directly. Task ID-2322411 PR #68699 closes #69939 closes #69965 X-original-commit: f7c95d9 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
tde-banana-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 30, 2021
A computed field on event may crash if current user is a portal user as it tries to access registrations to know if current user is already participating to the event. We also fix ACL on the registrations as most code already use it as sudo and do not access it directly. Only the event users or admins should access it directly. Task ID-2322411 PR odoo#68699 closes odoo#69939 X-original-commit: odoo/odoo@f7c95d9
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2021
A computed field on event may crash if current user is a portal user as it tries to access registrations to know if current user is already participating to the event. We also fix ACL on the registrations as most code already use it as sudo and do not access it directly. Only the event users or admins should access it directly. Task ID-2322411 PR #68699 closes #69939 closes #70105 X-original-commit: f7c95d9 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
RD
research & development, internal work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When creating an attendee, some fields may be added in the parameters.
We want the defaults values to have the priority on those parameters
(e.g. barcode code).
Task-2169118
Forward-Port-Of: #68699