Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] event: ignore fields which have a default value #69939

Closed

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 27, 2021

Purpose

When creating an attendee, some fields may be added in the parameters.
We want the defaults values to have the priority on those parameters
(e.g. barcode code).

Task-2169118

Forward-Port-Of: #68699

@robodoo
Copy link
Contributor

robodoo commented Apr 27, 2021

Pull request status dashboard

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Apr 27, 2021
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 27, 2021

Ping @tde-banana-odoo
Cherrypicking fa002ef of source #68699 failed

stderr:

16:14:13.041292 git.c:344               trace: built-in: git cherry-pick fa002ef4667435165bd776498cf12a78e4d609e5
error: Cherry-picking is not possible because you have unmerged files.
hint: Fix them up in the work tree, and then use 'git add/rm <file>'
hint: as appropriate to mark resolution and make a commit.
fatal: cherry-pick failed
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

Purpose
=======

When creating an attendee from frontend some fields may be added in
parameters, notably through inheritance (questions, ...). We want the
defaults values to have the priority on those parameters (e.g. barcode code).

Task ID-2322411
PR odoo#68699

X-Original-Commit: odoo/odoo@5391df9
@tde-banana-odoo tde-banana-odoo force-pushed the saas-11.3-11.0-registration-tde-WK8A-fw branch from 1fa6cbb to 16cdbd2 Compare April 27, 2021 14:39
A computed field on event may crash if current user is a portal user as it
tries to access registrations to know if current user is already participating
to the event.

We also fix ACL on the registrations as most code already use it as sudo and
do not access it directly. Only the event users or admins should access it
directly.

Task ID-2322411
PR odoo#68699

X-Original-Commit: odoo/odoo@f7c95d9
@tde-banana-odoo tde-banana-odoo force-pushed the saas-11.3-11.0-registration-tde-WK8A-fw branch from 16cdbd2 to 9d224fc Compare April 27, 2021 14:40
@tde-banana-odoo
Copy link
Contributor

@fw-bot r+

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 27, 2021
@tde-banana-odoo
Copy link
Contributor

@robodoo r+ rebase-ff

robodoo pushed a commit that referenced this pull request Apr 28, 2021
A computed field on event may crash if current user is a portal user as it
tries to access registrations to know if current user is already participating
to the event.

We also fix ACL on the registrations as most code already use it as sudo and
do not access it directly. Only the event users or admins should access it
directly.

Task ID-2322411
PR #68699

closes #69939

X-original-commit: f7c95d9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 28, 2021

Merge method set to rebase and fast-forward

@robodoo robodoo closed this Apr 28, 2021
@robodoo robodoo temporarily deployed to merge April 28, 2021 07:49 Inactive
tde-banana-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Apr 29, 2021
A computed field on event may crash if current user is a portal user as it
tries to access registrations to know if current user is already participating
to the event.

We also fix ACL on the registrations as most code already use it as sudo and
do not access it directly. Only the event users or admins should access it
directly.

Task ID-2322411
PR odoo#68699

closes odoo#69939

X-original-commit: odoo/odoo@f7c95d9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo pushed a commit that referenced this pull request Apr 29, 2021
A computed field on event may crash if current user is a portal user as it
tries to access registrations to know if current user is already participating
to the event.

We also fix ACL on the registrations as most code already use it as sudo and
do not access it directly. Only the event users or admins should access it
directly.

Task ID-2322411
PR #68699

closes #69939

closes #69965

X-original-commit: f7c95d9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
tde-banana-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Apr 30, 2021
A computed field on event may crash if current user is a portal user as it
tries to access registrations to know if current user is already participating
to the event.

We also fix ACL on the registrations as most code already use it as sudo and
do not access it directly. Only the event users or admins should access it
directly.

Task ID-2322411
PR odoo#68699

closes odoo#69939

X-original-commit: odoo/odoo@f7c95d9
robodoo pushed a commit that referenced this pull request Apr 30, 2021
A computed field on event may crash if current user is a portal user as it
tries to access registrations to know if current user is already participating
to the event.

We also fix ACL on the registrations as most code already use it as sudo and
do not access it directly. Only the event users or admins should access it
directly.

Task ID-2322411
PR #68699

closes #69939

closes #70105

X-original-commit: f7c95d9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@fw-bot fw-bot deleted the saas-11.3-11.0-registration-tde-WK8A-fw branch May 12, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants