Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] delivery: fix a recent fix and stop deleting invoiced order lines on update #73187

Closed
wants to merge 2 commits into from
Closed

[FIX] delivery: fix a recent fix and stop deleting invoiced order lines on update #73187

wants to merge 2 commits into from

Conversation

wtaferner
Copy link
Contributor

@wtaferner wtaferner commented Jul 3, 2021 •
edited
Loading

Description of the issue/feature this PR addresses:
As of #72859 on every update of the delivery line in a sale order ALL pickings are overwritten with the new carrier, no matter what...

To save you guys from more OPWs and desperate customers, let me help you with two things and I hope it is appreciated.

Current behavior before PR:
Updating shipping costs do overwrite carriers of done and processed (tracking reference) pickings and also deleting sale order lines (delivery line) already invoiced.

Desired behavior after PR is merged:

  • Only pickings are written, where we are kinda sure that it is wanted by the user, on updating the shipping costs on a sale order.
  • The user is stopped to update the shipping costs in case it was already invoiced.

Info: @wt-io-it

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Jul 3, 2021 •
edited
Loading

Pull request status dashboard

@wtaferner wtaferner mentioned this pull request Jul 3, 2021
Closed
@wtaferner
Copy link
Contributor Author

@nim-odoo @mart-e
FYI

@mart-e mart-e requested a review from a team July 5, 2021 06:00
@wtaferner
Copy link
Contributor Author

Alright, thx for your reviews and input, but who will tell it our beloved robot? 😉
I would, but the bot does not listen to me in this case and this is IMO a time critical bug which should be merged ASAP.

@wtaferner
Copy link
Contributor Author

@pimodoo @mart-e @Whenrow
May I ask you to merge? Everyone who was updating last week is having quite an issue with the code currently in place, so if there is some minor issue with this which I kinda doubt, we are better of to merge, right?

@pimodoo
Copy link
Collaborator

pimodoo commented Jul 9, 2021

@robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Jul 9, 2021

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Jul 9, 2021
@wtaferner
[FIX] delivery: do not delete delivery sale order lines in case alrea…
c40ab2b 
…dy invoiced

closes #73187

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
@robodoo robodoo closed this Jul 9, 2021
@robodoo robodoo temporarily deployed to merge July 9, 2021 09:48 Inactive
@fw-bot fw-bot mentioned this pull request Jul 9, 2021
Closed
@wtaferner wtaferner deleted the 13.0-fix_delivery_cases-wt branch July 9, 2021 11:02
@fw-bot
Copy link
Contributor

fw-bot commented Jul 13, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73479

@fw-bot fw-bot mentioned this pull request Jul 13, 2021
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Jul 14, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

7 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Jul 15, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

@fw-bot
Copy link
Contributor

fw-bot commented Jul 16, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

@fw-bot
Copy link
Contributor

fw-bot commented Jul 17, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

@fw-bot
Copy link
Contributor

fw-bot commented Jul 18, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

@fw-bot
Copy link
Contributor

fw-bot commented Jul 19, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

@fw-bot
Copy link
Contributor

fw-bot commented Jul 21, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

@fw-bot
Copy link
Contributor

fw-bot commented Jul 29, 2021

This pull request has forward-port PRs awaiting action (not merged or closed): #73624

This was referenced Jul 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mart-e mart-e mart-e left review comments

@Whenrow Whenrow Whenrow left review comments

@pimodoo pimodoo pimodoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wtaferner @robodoo @pimodoo @fw-bot @mart-e @Whenrow