Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] delivery: fix a recent fix and stop deleting invoiced order lines on update #74412

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jul 29, 2021

Description of the issue/feature this PR addresses:
As of #72859 on every update of the delivery line in a sale order ALL pickings are overwritten with the new carrier, no matter what...

To save you guys from more OPWs and desperate customers, let me help you with two things and I hope it is appreciated.

Current behavior before PR:
Updating shipping costs do overwrite carriers of done and processed (tracking reference) pickings and also deleting sale order lines (delivery line) already invoiced.

Desired behavior after PR is merged:

  • Only pickings are written, where we are kinda sure that it is wanted by the user, on updating the shipping costs on a sale order.
  • The user is stopped to update the shipping costs in case it was already invoiced.

Info: @wt-io-it

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #73624
Forward-Port-Of: #73187

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Jul 29, 2021
@robodoo
Copy link
Contributor

robodoo commented Jul 29, 2021

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 29, 2021

This PR targets saas-14.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Jul 29, 2021
robodoo pushed a commit that referenced this pull request Jul 29, 2021
…ew carrier

closes #74412

X-original-commit: 3dce2fd
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Wolfgang Taferner <wtaferner@users.noreply.github.com>
@robodoo robodoo closed this Jul 29, 2021
@robodoo robodoo temporarily deployed to merge July 29, 2021 13:47 Inactive
@fw-bot fw-bot deleted the saas-14.4-13.0-fix_delivery_cases-wt-ZU5x-fw branch August 12, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants