Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --update-list CLI option #9133

Closed
wants to merge 1 commit into from
Closed

Add --update-list CLI option #9133

wants to merge 1 commit into from

Conversation

dreispt
Copy link
Contributor

@dreispt dreispt commented Oct 19, 2015

CLI option to update the module list.
Using it allows to directly install newly added modules without going to the web GUI or updating the base module.

@mart-e
Copy link
Contributor

mart-e commented Oct 19, 2015

Hello,

This option will only work if you are in update mode (e.g. install another module).
Either it is explicitly specified in the command line (anyway we will usually do -U -i my_new_module), either we activate update_mode with the -U (but I am afraid activating the update mode would have more side effects).

Otherwise looks good for master

@dreispt
Copy link
Contributor Author

dreispt commented Oct 19, 2015

Should the help text mention it should be used with -d and -i?
Should I make a PR for master then?

@xmo-odoo
Copy link
Collaborator

Alternatively, wouldn't it make sense to update the modules list any time we're trying to install a new module? /cc @odony

@odony
Copy link
Contributor

odony commented Oct 19, 2015

Yes, we already have so many CLI parameters, it'd be much more in favor of merging this feature with the update/init mode itself. The likely reason why we didn't do that yet is the (small) extra cost of the addons_path scanning. But I think it would be ok to do it at the beginning of every install and/or update, not just for base (and in master, not a in stable version).

@xmo-odoo
Copy link
Collaborator

I went hunting for the origin of this expecting a revision 1 introduction but it turns out to be 00098e7: the restriction to "only when installing or updating base" seems somewhat arbitrary and is not explained.

@dreispt
Copy link
Contributor Author

dreispt commented Oct 19, 2015

That's even simpler. I can do that PR if you like.

@dreispt
Copy link
Contributor Author

dreispt commented May 9, 2016

PR made here: #9140

@dreispt dreispt closed this May 12, 2016
mart-e pushed a commit that referenced this pull request Sep 26, 2017
Was only done when updating base.
The cost of scanning the addons path should small in comparison to the update
time itself.

Followup of #9133
Closes #9140
nsa-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Sep 28, 2017
Was only done when updating base.
The cost of scanning the addons path should small in comparison to the update
time itself.

Followup of odoo#9133
Closes odoo#9140
nsa-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Sep 28, 2017
Was only done when updating base.
The cost of scanning the addons path should small in comparison to the update
time itself.

Followup of odoo#9133
Closes odoo#9140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants