[FIX] website: fix height of facebook block #98106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guillaume-gdi
force-pushed
the
master-fix-facebook-block-height-gdi
branch
from
f0ae725
to
e8446d9
Compare
Since [this commit], the values of the data attributes of the facebook block are no longer read with JQuerry so that when the block has a `data-x="false"` it is now interpreted in javascript as a character string containing the word "false" and not as a boolean This caused errors in the height of the block on the page. Steps to reproduce the bug: - drop a snippet - drop a Facebook snippet in it - grab it and move it somewhere else => the height of the block is too high. [this commit]: odoo@03c5526 task-2950329
Guillaume-gdi
force-pushed
the
master-fix-facebook-block-height-gdi
branch
from
e8446d9
to
131aa7f
Compare
|
As the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit, the values of the data attributes of the facebook
block are no longer read with JQuerry so that when the block has a
data-x="false"it is now interpreted in javascript as a characterstring containing the word "false" and not as a boolean This caused
errors in the height of the block on the page.
Steps to reproduce the bug:
=> the height of the block is too high.
task-2950329
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr