Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website: fix height of facebook block #98106

Commits on Aug 12, 2022

  1. [FIX] website: fix height of facebook block

    Since [this commit], the values of the data attributes of the facebook
    block are no longer read with JQuerry so that when the block has a
    `data-x="false"` it is now interpreted in javascript as a character
    string containing the word "false" and not as a boolean This caused
    errors in the height of the block on the page.
    
    Steps to reproduce the bug:
    - drop a snippet
    - drop a Facebook snippet in it
    - grab it and move it somewhere else
    
    => the height of the block is too high.
    
    [this commit]: odoo@03c5526
    
    task-2950329
    Guillaume-gdi committed Aug 12, 2022
    Copy the full SHA
    131aa7f View commit details
    Browse the repository at this point in the history