Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify the chat log #43

Closed
albertcui opened this issue Oct 4, 2014 · 7 comments · Fixed by #187
Closed

Prettify the chat log #43

albertcui opened this issue Oct 4, 2014 · 7 comments · Fixed by #187
Assignees

Comments

@albertcui
Copy link
Member

No description provided.

@albertcui albertcui self-assigned this Oct 4, 2014
@albertcui albertcui mentioned this issue Oct 6, 2014
@howardchung
Copy link
Member

I tried mapping chat messages to users in the parser, but ran into string encoding issues.

@howardchung
Copy link
Member

Spent some more time trying to fix this but couldn't. In the parser i attempt to construct a map of names to slots to enable mapping chat messages to players.

However, if the player has a unicode character in their name the hashmap fails. I don't know if it's an encoding issue, a hashing issue, or something else.

@howardchung
Copy link
Member

As a temporary fix I just set the slot to -1 if I can't find the slot in the map. If anyone wants to tackle this go ahead

@howardchung
Copy link
Member

Changed to a loop to compare element by element. Still not working. Probably gonna have to break down the string into bytes and see where they differ.

@howardchung
Copy link
Member

Match ID with this problem:
884544541

@howardchung
Copy link
Member

Think this is fixed in #162 , at least with regard to matching chat messages to players properly.

Don't know if you're still planning on "prettifying" it.

@howardchung
Copy link
Member

Albert wants to add colors for each player

@howardchung howardchung added this to the 1.3 milestone Jan 27, 2015
@howardchung howardchung assigned howardchung and unassigned albertcui Jan 30, 2015
@howardchung howardchung mentioned this issue Feb 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants