Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit CSS solution #3072

Open
howardchung opened this issue Feb 13, 2023 · 1 comment
Open

Revisit CSS solution #3072

howardchung opened this issue Feb 13, 2023 · 1 comment

Comments

@howardchung
Copy link
Member

Five years after #1189, I'm not such a big fan of styled-components:

  • It doesn't work well with syntax highlighting
  • It's a weird amalgamation of JS and CSS that loses out on tooling for both

It's probably too much work and not enough benefit to actually migrate everything, but if I were redoing this I'd probably just use CSS modules. Not sure what the state of the art is, so please chime in with thoughts!

@talal-najam
Copy link
Contributor

Agreed! I'd vote for CSS modules with Scss. Shared styles, theme / vars files, mixins and other scss goodies along with scoped module styles would be pretty clean in my opinion.

Alternate options could be Tailwind but I imagine that's not really everyone's cup of tea. Keen to hear what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants