Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Search for hero combinations in the data explorer #3161

Open
jzhao62 opened this issue Mar 14, 2024 · 3 comments
Open

Allow Search for hero combinations in the data explorer #3161

jzhao62 opened this issue Mar 14, 2024 · 3 comments

Comments

@jzhao62
Copy link

jzhao62 commented Mar 14, 2024

Is your feature request related to a problem? Please describe.
image
Currently the Data Explorer's hero choice only shows result in OR clause, usually when analyzing a match or review hero plays, you would want to search for heros you played against certain heros,
ex: Antimage vs Legion Commander, where LC is a hard counter to AM in certain sense. FIltering matches in high level bracket for antimages played against LC can let user analyze what is the best strategy when the user's team get out drafted, so he can approve

Describe the solution you'd like
Add an extra filter (Enemy filter, where you can provide a combination of enemy heros in the draft).
I think the API already support it, and this will be a feature where other pro data analytic platforms does not offer

@howardchung
Copy link
Member

You can probably modify the SQL query to achieve this (but we could maybe add a UI element for it)

@jzhao62
Copy link
Author

jzhao62 commented Mar 16, 2024

i think i can add an extra filter (enemy filter) in the UI so the sql can be auto generated, i will provide a PR for this one

@jzhao62
Copy link
Author

jzhao62 commented Mar 18, 2024

  • or add it in the combo page, the combo page could probably add a more detailed filters
  • as the Data Explorer page seems only relevant to pro matches
    Screenshot_20240318_021859

Screenshot_20240318_022059
to allow more granular filter in the combo page, like what is available in dotabuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants