-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Github provider #248
Comments
@ravisuhag @AkarshSatija @bsushmith @singhvikash11 @rahmatrhd Proposed Solution: type Access struct {
ID string
- Status string // active | revoked
+ Status string // pending | active | revoked | canceled/ignored
AccountID string
AccountType string
ResourceID string
Permissions []string
ExpirationDate *time.Time
AppealID string
RevokedBy string
RevokedAt *time.Time
RevokeReason string
CreatedAt time.Time
UpdatedAt time.Time
} For all the provider which will have a direct access, this pending state will be skipped. For an invite based approval the pending state holds true. We will also have to make an API to see if the user have accepted the invite or not to proceed to the active state of access. Access: + 1. pending
2. active
+2. canceled/ignored
3. revoked |
for a case when the invitation is not accepted by the user, we might need another access status called |
@rahmatrhd yes, was thinking to add that. Should we rename |
@Chief-Rishab we need to think of statuses of irrespective of github though. |
@ravisuhag we're assuming the invitation-based membership might be common for other providers (need to validate further). That aside, IMO |
Github/Gitlab (and other public SAAS based platforms) do not expose the user email to public by default. Currently we were only using the user email to grant/revoke access to the resources in Guardian since all those private SaaS providers had option to work with user email. The APIs in Github/Gitlab are using the To counter this problem, we propose to get the |
Summary
We need to support access management of Github
Proposed solution
The text was updated successfully, but these errors were encountered: