feat!: new v1beta2 asset models #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StewartJingga
changed the title
scortier
force-pushed
the
v1beta2-models
branch
from
90d89ad
to
676b4bf
Compare
scortier
changed the title
|
Picking up on reviewing this PR, have good context, so will review the changes. Mas @StewartJingga you can also check once, on the changes I have made. Let me know if I'm missing something. |
GrayFlash
requested changes
Aug 7, 2022
|
Rest of the changes in plugins LGTM!! |
GrayFlash
approved these changes
Aug 10, 2022
ravisuhag
approved these changes
Aug 23, 2022
|
@StewartJingga Can you link the corresponding issue with details to this PR. Also, would this change break the recipe contracts by any chance? If, from a usage perspective, there is a breaking change - can you also add details about what is breaking and what needs to be done to accommodate these in the corresponding issue. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package to be fixed: