fix: close sinks after records are written #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
close-sinks-after-write
branch
4 times, most recently
from
2f2ffbd
to
48f7901
Compare
- Split stream.Close() into Shutdown() and Close(). Shutdown() is expected to be called once all the records are extracted and Close() is expected to be called once all records are written by sinks. If Close() is called first, it will call Shutdown() internally. - Close the File instance in file sink's Close() method. Minor refactoring to improve perf for ndjson output (avoid string concat).
sudo-suhas
force-pushed
the
close-sinks-after-write
branch
from
48f7901
to
64fe500
Compare
haveiss
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected to be called once all the records are extracted and Close()
is expected to be called once all records are written by sinks. If
Close() is called first, it will call Shutdown() internally.
refactoring to improve perf for ndjson output (avoid string concat).
(builds on #446 to avoid conflicts)
Closes #380.