Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic from redirection server #36

Closed
whoAbhishekSah opened this issue Jul 28, 2021 · 0 comments
Closed

Remove logic from redirection server #36

whoAbhishekSah opened this issue Jul 28, 2021 · 0 comments

Comments

@whoAbhishekSah
Copy link
Member

As of now, the redirection server needs to fetch the code from query params(once the OAuth consent is given) and enrich add workspace in the payload to make a POST call to Siren for the code exchange.
Can we think of trying to remove this logic, and make the flow transparent, where the redirection server can just redirect the request further to Siren and get a response back without needing extra work of payload creation and enrichment.

@mabdh mabdh closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants