Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert): add create alert with namespace API #164

Merged
merged 5 commits into from
Jan 10, 2023
Merged

feat(alert): add create alert with namespace API #164

merged 5 commits into from
Jan 10, 2023

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jan 7, 2023 •
edited
Loading

@mabdh mabdh linked an issue Jan 7, 2023 that may be closed by this pull request
Post alert with namespace API #163
Closed
@coveralls
Copy link

coveralls commented Jan 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3871723135

  • 22 of 45 (48.89%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 77.611%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/alerts.go 2 4 50.0%
core/subscription/service.go 0 3 0.0%
internal/api/v1beta1/alert.go 11 19 57.89%
plugins/providers/cortex/service.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
core/subscription/service.go 1 83.06%
Totals Coverage Status
Change from base Build 3616688183: -0.2%
Covered Lines: 2846
Relevant Lines: 3667
💛 - Coveralls

@mabdh mabdh changed the title Create Alert with namespace API feat(alert): add create alert with namespace API Jan 7, 2023
@mabdh mabdh force-pushed the alert-namespace-api branch 2 times, most recently from 9121ec6 to 2d00932 Compare January 7, 2023 13:44
rahmatrhd
rahmatrhd approved these changes Jan 9, 2023
View reviewed changes
core/alert/service.go Show resolved Hide resolved
internal/api/v1beta1/alert.go Show resolved Hide resolved
@mabdh mabdh merged commit fb8ebbd into main Jan 10, 2023
@mabdh mabdh deleted the alert-namespace-api branch January 10, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post alert with namespace API
3 participants
@mabdh @coveralls @rahmatrhd