Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re-revert) feat: add silencing notification #169

Merged
merged 1 commit into from
Feb 6, 2023
Merged

(re-revert) feat: add silencing notification #169

merged 1 commit into from
Feb 6, 2023

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Feb 3, 2023

No description provided.

@mabdh mabdh linked an issue Feb 3, 2023 that may be closed by this pull request
@mabdh mabdh changed the title re-revert feat: add alert silencing (re-revert) feat: add silencing notification Feb 3, 2023
@mabdh
Copy link
Member Author

mabdh commented Feb 3, 2023

re-revert the PR #167

@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4080725895

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 614 of 790 (77.72%) changed or added relevant lines in 26 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.003%) to 77.209%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/notification/notification.go 21 22 95.45%
internal/api/v1beta1/alert.go 12 13 92.31%
internal/store/postgres/subscription.go 3 6 50.0%
core/notification/dispatch_subscriber_service.go 107 111 96.4%
core/silence/silence.go 37 41 90.24%
internal/api/v1beta1/silence.go 62 66 93.94%
internal/store/postgres/alerts.go 9 13 69.23%
core/notification/service.go 46 51 90.2%
plugins/providers/cortex/service.go 0 5 0.0%
core/silence/type.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
core/notification/notification.go 1 91.67%
plugins/queues/postgresq/queue.go 2 72.62%
core/notification/service.go 3 82.29%
Totals Coverage Status
Change from base Build 4072599184: 0.003%
Covered Lines: 3381
Relevant Lines: 4379

💛 - Coveralls

@mabdh mabdh requested a review from rahmatrhd February 6, 2023 04:11
@ravisuhag ravisuhag merged commit 8758d53 into main Feb 6, 2023
@ravisuhag ravisuhag deleted the silences branch February 6, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts & Notification Silencing
4 participants