#356 Added exclusions to support LF build automation #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
JPWKU
reviewed
Nov 6, 2018
| @@ -94,4 +94,6 @@ open-metadata-implementation/access-services/subject-area/subject-area-server/sr | |||
| # exclude temporary lock files | |||
| *.lock | |||
| log | |||
| # m2 repo used by linux foundation build | |||
| **/m2repo*/** | |||
There was a problem hiding this comment.
Should we not specifically exclude the maven-metadata.xml here so it still scans the relevant files in m2repo?
There was a problem hiding this comment.
Is this folder equivalent of default .m2 local repo? If yes, in my opinion should be excluded.
mandy-chessell
approved these changes
Nov 7, 2018
bogdan-sava
approved these changes
Nov 7, 2018
bogdan-sava
pushed a commit
that referenced
this pull request
Aug 30, 2019
#356 Added exclusions to support LF build automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nigel Jones nigel.l.jones+git@gmail.com