Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture additional code coverage data #5159

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Conversation

planetf1
Copy link
Member

@planetf1 planetf1 commented May 5, 2021

  • captures code coverage data for unit tests (only) [fvt can follow] for gradle build
  • Since we only have a verification build in gradle, it is done there, ie for a PR - not a merge
  • output is attached as a build artifact. It includes a CSV, as well as a tree of html files
  • Report is only ordered by package name. There is no breakdown by artifact/directory (the plugin does not support this)

See #3969 for more info

…uild artifact

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1 planetf1 mentioned this pull request May 5, 2021
5 tasks
@planetf1 planetf1 marked this pull request as draft May 6, 2021 07:30
@planetf1
Copy link
Member Author

planetf1 commented May 6, 2021

After reviewing results, some further work is needed. The report is not uploaded, as it is not run in the current './gradlew build' invocation. the task needs to be run explicitly (easy - run './gradlew codeCoverageReport - except that then the FVTs would run twice)
Need to review the network of task dependencies to determine the best to add to ensure the report is built at the correct time. The FVTs themselves probably need modifying so that they run when the assembly is rebuilt or tests modified, but not at other times
Moved to draft

@planetf1
Copy link
Member Author

planetf1 commented Jun 9, 2021

  • Added support to maven poms for our FVT tests to try and capture code coverage data there-
  • removed sonar exclusions from FVT tests (I think caused by original heavy types testing code)

@planetf1 planetf1 changed the title Capture code coverage data in gradle Capture additional code coverage data Jun 9, 2021
@planetf1
Copy link
Member Author

planetf1 commented Jun 9, 2021

Merging, as this should improve sonar reports, but due to the pipeline setup we'll only verify once merged. Further changes to improve code coverage capture can follow in other PRs.

@planetf1 planetf1 marked this pull request as ready for review June 9, 2021 12:55
@planetf1 planetf1 enabled auto-merge June 9, 2021 12:55
@planetf1 planetf1 merged commit e4348a4 into odpi:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant