Shadowed field in TransitLogRecord constructor

[jwillikers]

As of Quill v1.3.1, Clang 10.0.0 generates warnings for two shadowed fields in the TransitLogRecord constructor.
I've pasted the output below.

In file included from _deps/quill-src/quill/include/quill/Quill.h:10:
_deps/quill-src/quill/include/quill/detail/BackendWorker.h:145:37: error: constructor parameter 'thread_context' shadows the field 'thread_context' of 'TransitLogRecord' [-Werror,-Wshadow-field-in-constructor]
    TransitLogRecord(ThreadContext* thread_context, std::unique_ptr<RecordBase> base_record)
                                    ^
_deps/quill-src/quill/include/quill/detail/BackendWorker.h:155:20: note: previous declaration is here
    ThreadContext* thread_context;
                   ^
_deps/quill-src/quill/include/quill/detail/BackendWorker.h:145:81: error: constructor parameter 'base_record' shadows the field 'base_record' of 'TransitLogRecord' [-Werror,-Wshadow-field-in-constructor]
    TransitLogRecord(ThreadContext* thread_context, std::unique_ptr<RecordBase> base_record)
                                                                                ^
_deps/quill-src/quill/include/quill/detail/BackendWorker.h:156:33: note: previous declaration is here
    std::unique_ptr<RecordBase> base_record;

[odygrd]

Thanks for reporting : )
Please check with the latest commit from master!

[jwillikers]

That fixed it, thanks again 👍