Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twisted 22 / removal of several old functions #525

Open
jbleyel opened this issue May 17, 2022 · 1 comment
Open

twisted 22 / removal of several old functions #525

jbleyel opened this issue May 17, 2022 · 1 comment

Comments

@jbleyel
Copy link
Contributor

jbleyel commented May 17, 2022

https://github.com/twisted/twisted/releases/tag/twisted-22.1.0rc1
->

Deprecations and Removals

twisted.web.client.getPage, twisted.web.client.downladPage, and the associated implementation classes (HTTPPageGetter, HTTPPageDownloader, HTTPClientFactory, HTTPDownloader) have been removed because they do not segregate cookies by domain. They were deprecated in Twisted 16.7.0 in favor of twisted.web.client.Agent. GHSA-92x2-jw7w-xvvx. (#10295)
@jbleyel
Copy link
Contributor Author

jbleyel commented May 17, 2022

We have several options for twisted.web.client.getPage and twisted.web.client.downladPage

  • urllib.request
  • requests
  • treq
  • twisted Agent

I'm not sure what's the best case.

PRO/CONS are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbleyel