-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Outputs for OffsetConverter #1054
Multiple Outputs for OffsetConverter #1054
Conversation
Can't figure out what problem |
I'd suggest to close this and have an example that models the same thing using multiple components instead. @fwitte asked about an electrolyser and waste heat, but the example could also be a CHP with increasing electrical and reducing thermal efficiency towards full load. |
I also quickly looked into the |
I see. Then, I accept this (also as a fix to #1053). |
I will make another PR, I would like to change the naming conventions and styles of the equations (to have the exact same structure as in the |
This PR enables the OffsetConverter to output two (or more) flows with part-load depending efficiencies.
outputs
are allowed to contain multiple busses.coefficients
expects a dictionary, where the keys are the output busses and the values are the tuples containing the necessary parameters. I took the liberty to implement a deprecation warning for the old behaviour (passing a tuple without specifying the output bus it corresponds to). This way, the OffsetConverter is more in line with the regular Converter and there is less room for confusion. But this is totally up for debate!