-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge configurations into pyproject.toml
#1073
Conversation
@oemof-developer: I think this should be ready for review. There are two remaining questions:
Quick explanation/overview of the changes:
|
One more comment to the build system: I changed from I am very open to discuss this btw. because I am by no means an expert in this, according to this post, it seems setuptools should provide editable installation for pure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, you questions:
Is anybody knowledgeable if pydocstyle actually does anything?
I don't but I think this is nothing to be fixed here. If it does not do anything, it should be removed independend from the switch to pyproject.toml.
The black error is in some source files I never touched, should that be fixed or not?
This is an unrelated problem, as it should have been wrong before you changed things. So, it should not be included in this merge request.
The same is true for the last comment I gave. Making support for Python 3.11 (which is tested) official might be something for a separate merge.
PS: I was a bit surprised that https://github.com/oemof/oemof/wiki/How-to-release still works exactly the same way as before.
One more question, what is the VERSION file for? VERSION was deleted, also see #712 |
…e source of truth
Resolve #1072
Resolve #712