-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all appearences of pkg_resources except one #101
Conversation
Apparently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the changes require Python 3.9, older versions should be removed from both, the the list of supported versions and the testing.
For the failing test, I also have no clue. But I am reluctant to just wave it through.
So we would need to drop support for python 3.8 and lower. Python 3.8 is the default version of ubuntu 20.04 LTS, which will be around for another two years, I guess... I do not really know, how to feel about that. In my opinion it might make sense to move the lower python version limit to 3.9, but that might break things for a couple of people. What do you think? |
So, all tests (except the one that did not work in the first place) are working with python 3.9 and 3.10. Python 3.11 has installation issues with So the question remains, whether to drop support of older versions. I'll let you guys decide on this, since I do not (yet) use the software... |
Honestly, that's the reason why I dist-upgraded. |
I also vote for dropping support for python 3.8 |
I also vote for dropping support for python 3.8 |
Anybody has an idea, what the reason for the failing test is? |
which failing tests? I guess this got somehow solved in another issue?! |
... I oversaw it was fixed by merging dev into here 😀 Also, there should be some kind of warning before releasing this into the wild, right? Suddenly disappearing support for 3.8 might be inconvenient. |
Yes, that's right. I'm not sure how many active users there are, though. Following the release convention, we haven't even released a feature, only bug fixes :D, so there is no stable version yet. v0.0.3 How is this normally handled? You would raise a warning in another release? Or is it maybe fine to set a tag before and mention it in the warning? |
This should not be merged without setting a tag before, due to the dropped support of pyton3.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A warning for dropped support of python 3.8 should be added and possibly the option to use a version/tag which still supports 3.8
@nailend: since this has been merged as well there is no more point in the warning message :D. People with python < 3.9 will not be able to install the latest version anymore. I would suggest downgrade the python requirement again, make a release, upgrade it again and make another release 2 or so weeks later. |
Ran the tests, all working fine except for the
test_examples_datapackages_scripts_infer
. There the original implementation already fails locally for me. So I did not touch that.See #100