Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current state to cookiecutter skeleton #201

Merged
merged 13 commits into from
May 20, 2020

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented May 20, 2020

No description provided.

@pep8speaks
Copy link

pep8speaks commented May 20, 2020

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 41:80: E501 line too long (81 > 79 characters)
Line 65:80: E501 line too long (80 > 79 characters)
Line 71:80: E501 line too long (82 > 79 characters)
Line 79:80: E501 line too long (88 > 79 characters)

Comment last updated at 2020-05-20 11:52:07 UTC

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request introduces 5 alerts and fixes 29 when merging 3588cab into f6439ef - view on LGTM.com

new alerts:

  • 2 for Module is imported more than once
  • 2 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 8 for Unused import
  • 7 for Variable defined multiple times
  • 5 for First parameter of a method is not named 'self'
  • 5 for Use of 'global' at module level
  • 1 for Unnecessary pass
  • 1 for Redundant comparison
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Mismatch between signature and use of an overridden method

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request introduces 2 alerts and fixes 30 when merging 4ca45cf into f6439ef - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 8 for Unused import
  • 7 for Variable defined multiple times
  • 5 for First parameter of a method is not named 'self'
  • 5 for Use of 'global' at module level
  • 1 for Unnecessary pass
  • 1 for Redundant comparison
  • 1 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Mismatch between signature and use of an overridden method

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request introduces 2 alerts and fixes 30 when merging 20e484a into f6439ef - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 8 for Unused import
  • 7 for Variable defined multiple times
  • 5 for First parameter of a method is not named 'self'
  • 5 for Use of 'global' at module level
  • 1 for Unnecessary pass
  • 1 for Redundant comparison
  • 1 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Mismatch between signature and use of an overridden method

@fwitte fwitte merged commit 03a0b5f into feature/joss_paper_review May 20, 2020
@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request introduces 2 alerts and fixes 30 when merging 196683a into f6439ef - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once
  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 8 for Unused import
  • 7 for Variable defined multiple times
  • 5 for First parameter of a method is not named 'self'
  • 5 for Use of 'global' at module level
  • 1 for Unnecessary pass
  • 1 for Redundant comparison
  • 1 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Mismatch between signature and use of an overridden method

@fwitte fwitte deleted the feature/cookiecutter branch May 20, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants